Forked gems and hacks still necessary?

[mfaerevaag]

Hey! Awesome app you've made. I'm going to be doing some work on the project, so I'm going to be asking some questions just to get up to speed with the code base.. :-)

They are mainly about some forked gems which have fallen behind their upstreams and are becoming a pain to maintain. Also, an hack which I can't wrap my head around.

auto_html:
This commit fixes some gsub problem in the auto_html gem. Can anyone remember how to recreate the problem? Asking because it is a pain keeping a forked gem up to date with upstream. Therefore it would be great if the problem "went away" or to submit a pull-request to upstream.

cancan:
Same thing as above, really.

config/initializers/acts_as_taggable_on_hacks.rb:
Not really sure what the acts_as_taggable_on_hacks.rb is good for, but I can't seem to get it to run with it not being commented out. What does it do? :-)

[emiltin]

Hi Markus,

auto_html: See dejan/auto_html#48.
cancan: See mbleigh/acts-as-taggable-on#239.

[emiltin]

I think the auto_html problem might have been related to ruby 1.8 or 1.9.
For cancan, I think the problem might have been related to Rails 3.

Both things probably needs checking. The links above should give you enough info to check if the problem has gone away with latest versions.

[emiltin]

Hope this helps :-)

[mfaerevaag]

Thanks! I'll see if I can't figure it out...

And in case you were wondering why the sudden interest, I'm writing on behalf of BIT BLUEPRINT and in English, in the sake of open source :-)

[mfaerevaag]

I'm confused. Does the issue in acts-as-taggable (which just got closed) have anything to do with cancan? Since the this app uses your fork of cancan.

[emiltin]

sorry for the confusion. the acts_as_taggable_on_hacks.rb stuff is of course not related to cancan. the issue at mbleigh/acts-as-taggable-on#239, explains what the issue is with acts_as_taggable_on. as you can see, the code that a user posted, is what is found in our project in config/initializers/acts_as_taggable_on_hacks.rb. i don't know if the fix is still required.

regarding cancan, i posted an issue at ryanb/cancan#623. it seems cancan is not being maintained by the original author, but there's an active fork at https://github.com/cancancommunity/cancancan.

[mfaerevaag]

Ah, I see. Thank you for the clarification and taking the time to dig up links to the issues!

[emiltin]

can i close this?

[mfaerevaag]

Yes, thank you

On Jan 7, 2015, 17:06, at 17:06, Emil Tin notifications@github.com wrote:

can i close this?

---

Reply to this email directly or view it on GitHub:
#4 (comment)