Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(steps): implement zero-variance filter #48

Merged
merged 5 commits into from
Apr 5, 2024
Merged

feat(steps): implement zero-variance filter #48

merged 5 commits into from
Apr 5, 2024

Conversation

jitingxu1
Copy link
Collaborator

@jitingxu1 jitingxu1 commented Mar 28, 2024 •
edited
Loading

Add zero variance filter:

  1. remove numeric features with 0 variance
    • used a tolerance level for considering variance as zero. Columns with variance less than this tolerance will be removed.
      Default is 1e-4.
  2. remove non-numeric columns with only 1 constant value
    • NULL value is not counted in the nunique()

Issues
#42

@jitingxu1 jitingxu1 mentioned this pull request Mar 29, 2024
Closed
1 task
deepyaman
deepyaman requested changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall; relatively minor requests!

ibisml/steps/feature_selection.py Outdated Show resolved Hide resolved
ibisml/steps/feature_selection.py Outdated Show resolved Hide resolved
ibisml/steps/feature_selection.py Outdated Show resolved Hide resolved
ibisml/steps/feature_selection.py Outdated Show resolved Hide resolved
tests/test_feature_selection.py Outdated Show resolved Hide resolved
@deepyaman deepyaman changed the title feat: zero variance filter feat(step): implement zero-variance filter Apr 4, 2024
@deepyaman deepyaman changed the title feat(step): implement zero-variance filter feat(steps): implement zero-variance filter Apr 5, 2024
@jitingxu1 jitingxu1 requested a review from deepyaman April 5, 2024 17:50
@jitingxu1
Copy link
Collaborator Author

@deepyaman Handled the request, please take another look when you have a chance. Thanks

@deepyaman deepyaman merged commit 3e64906 into ibis-project:main Apr 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepyaman deepyaman Awaiting requested review from deepyaman

Assignees
No one assigned
Labels
None yet
Projects
Ibis planning and roadmap
Status: done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jitingxu1 @deepyaman