Skip to content

Commit

Permalink
feat(sqlite): implement caching support
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud committed Aug 9, 2023
1 parent 04461d5 commit 0677f8d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 25 deletions.
24 changes: 0 additions & 24 deletions ibis/backends/tests/test_client.py
Expand Up @@ -224,9 +224,6 @@ def tmpcon(alchemy_con):
"be switched from using atexit to weakref.finalize",
)
@mark.notimpl(["trino", "druid"], reason="doesn't implement temporary tables")
@mark.notyet(
["sqlite"], reason="sqlite only support temporary tables in temporary databases"
)
@mark.never(
["mssql"],
reason="mssql supports support temporary tables through naming conventions",
Expand Down Expand Up @@ -1144,9 +1141,6 @@ def test_create_table_timestamp(con, temp_table):


@mark.notimpl(["clickhouse", "datafusion", "bigquery", "impala", "trino", "druid"])
@mark.notyet(
["sqlite"], reason="sqlite only support temporary tables in temporary databases"
)
@mark.never(
["mssql"],
reason="mssql supports support temporary tables through naming conventions",
Expand All @@ -1164,9 +1158,6 @@ def test_persist_expression_ref_count(con, alltypes):


@mark.notimpl(["clickhouse", "datafusion", "bigquery", "impala", "trino", "druid"])
@mark.notyet(
["sqlite"], reason="sqlite only support temporary tables in temporary databases"
)
@mark.never(
["mssql"],
reason="mssql supports support temporary tables through naming conventions",
Expand All @@ -1178,9 +1169,6 @@ def test_persist_expression(alltypes):


@mark.notimpl(["clickhouse", "datafusion", "bigquery", "impala", "trino", "druid"])
@mark.notyet(
["sqlite"], reason="sqlite only support temporary tables in temporary databases"
)
@mark.never(
["mssql"],
reason="mssql supports support temporary tables through naming conventions",
Expand All @@ -1194,9 +1182,6 @@ def test_persist_expression_contextmanager(alltypes):


@mark.notimpl(["clickhouse", "datafusion", "bigquery", "impala", "trino", "druid"])
@mark.notyet(
["sqlite"], reason="sqlite only support temporary tables in temporary databases"
)
@mark.never(
["mssql"],
reason="mssql supports support temporary tables through naming conventions",
Expand All @@ -1213,9 +1198,6 @@ def test_persist_expression_contextmanager_ref_count(con, alltypes):


@mark.notimpl(["clickhouse", "datafusion", "bigquery", "impala", "trino", "druid"])
@mark.notyet(
["sqlite"], reason="sqlite only support temporary tables in temporary databases"
)
@mark.never(
["mssql"],
reason="mssql supports support temporary tables through naming conventions",
Expand Down Expand Up @@ -1249,9 +1231,6 @@ def test_persist_expression_multiple_refs(con, alltypes):


@mark.notimpl(["clickhouse", "datafusion", "bigquery", "impala", "trino", "druid"])
@mark.notyet(
["sqlite"], reason="sqlite only support temporary tables in temporary databases"
)
@mark.never(
["mssql"],
reason="mssql supports support temporary tables through naming conventions",
Expand All @@ -1266,9 +1245,6 @@ def test_persist_expression_repeated_cache(alltypes):


@mark.notimpl(["clickhouse", "datafusion", "bigquery", "impala", "trino", "druid"])
@mark.notyet(
["sqlite"], reason="sqlite only support temporary tables in temporary databases"
)
@mark.never(
["mssql"],
reason="mssql supports support temporary tables through naming conventions",
Expand Down
2 changes: 1 addition & 1 deletion ibis/backends/tests/test_examples.py
Expand Up @@ -13,7 +13,7 @@
reason="nix on linux cannot download duckdb extensions or data due to sandboxing",
raises=OSError,
)
@pytest.mark.notimpl(["dask", "datafusion", "pyspark", "sqlite"])
@pytest.mark.notimpl(["dask", "datafusion", "pyspark"])
@pytest.mark.notyet(["bigquery", "clickhouse", "druid", "impala", "mssql", "trino"])
@pytest.mark.parametrize(
("example", "columns"),
Expand Down

0 comments on commit 0677f8d

Please sign in to comment.