test(oracle): add snapshots and followup notes

ibis/backends/oracle/__init__.py

@@ -387,6 +387,8 @@ def _metadata(self, query: str) -> Iterable[tuple[str, dt.DataType]]:
         if isinstance(sg_expr, sg.exp.Table):
             sg_expr = sg.select(STAR).from_(sg_expr)
 
+        # TODO(gforsyth): followup -- this should probably be made a default
+        # transform for quoting backends
         def transformer(node):
             if isinstance(node, sg.exp.Table):
                 return sg.table(node.name, quoted=True)
@@ -461,6 +463,8 @@ def transformer(node):
             yield name, typ
 
     def _fetch_from_cursor(self, cursor, schema: sch.Schema) -> pd.DataFrame:
+        # TODO(gforsyth): this can probably be generalized a bit and put into
+        # the base backend (or a mixin)
         import pandas as pd
 
         from ibis.backends.oracle.converter import OraclePandasData

ibis/backends/tests/snapshots/test_interactive/test_default_limit/oracle/out.sql

@@ -0,0 +1,5 @@
+SELECT
+  "t0"."id",
+  "t0"."bool_col" = 1 AS "bool_col"
+FROM "functional_alltypes" "t0"
+FETCH FIRST 11 ROWS ONLY

ibis/backends/tests/snapshots/test_interactive/test_disable_query_limit/oracle/out.sql

@@ -0,0 +1,5 @@
+SELECT
+  "t0"."id",
+  "t0"."bool_col" = 1 AS "bool_col"
+FROM "functional_alltypes" "t0"
+FETCH FIRST 11 ROWS ONLY

ibis/backends/tests/snapshots/test_interactive/test_interactive_execute_on_repr/oracle/out.sql

@@ -0,0 +1,19 @@
+SELECT
+  SUM("t1"."bigint_col") AS "Sum(bigint_col)"
+FROM (
+  SELECT
+    "t0"."id",
+    "t0"."bool_col" = 1 AS "bool_col",
+    "t0"."tinyint_col",
+    "t0"."smallint_col",
+    "t0"."int_col",
+    "t0"."bigint_col",
+    "t0"."float_col",
+    "t0"."double_col",
+    "t0"."date_string_col",
+    "t0"."string_col",
+    "t0"."timestamp_col",
+    "t0"."year",
+    "t0"."month"
+  FROM "functional_alltypes" "t0"
+) "t1"

ibis/backends/tests/snapshots/test_interactive/test_respect_set_limit/oracle/out.sql

@@ -0,0 +1,10 @@
+SELECT
+  *
+FROM (
+  SELECT
+    "t0"."id",
+    "t0"."bool_col" = 1 AS "bool_col"
+  FROM "functional_alltypes" "t0"
+  FETCH FIRST 10 ROWS ONLY
+) "t2"
+FETCH FIRST 11 ROWS ONLY