fix(flink): re-implement ops.ApproxCountDistinct

ibis-project · Nov 5, 2023 · 2e3a5a0 · 2e3a5a0
1 parent 0076c25
commit 2e3a5a0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ibis/backends/flink/registry.py b/ibis/backends/flink/registry.py
@@ -4,7 +4,7 @@
 
 import ibis.common.exceptions as com
 import ibis.expr.operations as ops
-from ibis.backends.base.sql.registry import fixed_arity, helpers, unary
+from ibis.backends.base.sql.registry import aggregate, fixed_arity, helpers, unary
 from ibis.backends.base.sql.registry import (
     operation_registry as base_operation_registry,
 )
@@ -389,6 +389,7 @@ def _timestamp_from_ymdhms(
         ops.Degrees: unary("degrees"),
         ops.Radians: unary("radians"),
         # Unary aggregates
+        ops.ApproxCountDistinct: aggregate.reduction("approx_count_distinct"),
         ops.CountStar: _count_star,
         # String operations
         ops.StringLength: unary("char_length"),

diff --git a/ibis/backends/tests/test_aggregation.py b/ibis/backends/tests/test_aggregation.py
@@ -533,7 +533,6 @@ def mean_and_std(v):
             id="approx_nunique",
             marks=[
                 pytest.mark.notimpl(["polars"], raises=com.OperationNotDefinedError),
-                pytest.mark.notimpl(["flink"], "WIP", raises=Py4JError),
             ],
         ),
         param(