refactor(ir): impure values are never dereferencible

ibis/expr/operations/generic.py

@@ -185,13 +185,7 @@ class Constant(Scalar, Singleton):
 
 @public
 class Impure(Value):
-    _counter = itertools.count()
-    uid: Optional[int] = None
-
-    def __init__(self, uid, **kwargs):
-        if uid is None:
-            uid = next(self._counter)
-        super().__init__(uid=uid, **kwargs)
+    pass
 
 
 @public

ibis/expr/operations/tests/test_generic.py

@@ -146,10 +146,6 @@ def test_NULL():
 
 
 @pytest.mark.parametrize("op", [ops.RandomScalar, ops.RandomUUID])
-def test_unique_impure_values(op):
-    assert op() != op()
-    assert hash(op()) != hash(op())
-
-    node = op()
-    other = node.copy()
-    assert node == other
+def test_impure_values_are_equal(op):
+    assert op() == op()
+    assert hash(op()) == hash(op())

ibis/expr/tests/test_newrels.py

@@ -1618,7 +1618,7 @@ def test_impure_operation_dereferencing(func):
 
     expected = ops.Project(
         parent=t1,
-        values={"x": t1.x, "y": t1.y, "z": t1.y.cast("string")},
+        values={"x": t1.x, "y": t1.y, "z": impure.cast("string")},
     )
     assert t2.op() == expected
 

ibis/expr/types/relations.py

@@ -169,7 +169,7 @@ def dereference_mapping(parents):
                 while isinstance(v, ops.Field) and v not in mapping:
                     mapping[v] = ops.Field(parent, k)
                     v = v.rel.values.get(v.name)
-            elif v not in mapping:
+            elif v not in mapping and not v.find(ops.Impure):
                 # do not dereference literal expressions
                 mapping[v] = ops.Field(parent, k)