refactor(pyarrow): remove unnecessary calls to combine_chunks

ibis-project · Jul 5, 2023 · c026d2d · c026d2d
1 parent c099302
commit c026d2d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 19 deletions.
diff --git a/ibis/backends/base/__init__.py b/ibis/backends/base/__init__.py
@@ -288,14 +288,9 @@ def to_pyarrow(
         if isinstance(expr, ir.Table):
             return table
         elif isinstance(expr, ir.Column):
-            # Column will be a ChunkedArray, `combine_chunks` will
-            # flatten it
-            if len(table.columns[0]):
-                return table.columns[0].combine_chunks()
-            else:
-                return pa.array(table.columns[0])
+            return table[0]
         elif isinstance(expr, ir.Scalar):
-            return table.columns[0][0]
+            return table[0][0]
         else:
             raise ValueError
 

diff --git a/ibis/backends/duckdb/__init__.py b/ibis/backends/duckdb/__init__.py
@@ -738,14 +738,9 @@ def to_pyarrow(
         if isinstance(expr, ir.Table):
             return table
         elif isinstance(expr, ir.Column):
-            # Column will be a ChunkedArray, `combine_chunks` will
-            # flatten it
-            if len(table.columns[0]):
-                return table.columns[0].combine_chunks()
-            else:
-                return pa.array(table.columns[0])
+            return table[0]
         elif isinstance(expr, ir.Scalar):
-            return table.columns[0][0]
+            return table[0][0]
         else:
             raise ValueError
 

diff --git a/ibis/backends/polars/__init__.py b/ibis/backends/polars/__init__.py
@@ -439,15 +439,11 @@ def to_pyarrow(
         limit: int | None = None,
         **kwargs: Any,
     ):
-        pa = self._import_pyarrow()
         result = self._to_pyarrow_table(expr, params=params, limit=limit, **kwargs)
         if isinstance(expr, ir.Table):
             return result
         elif isinstance(expr, ir.Column):
-            if len(column := result[0]):
-                return column.combine_chunks()
-            else:
-                return pa.array(column)
+            return result[0]
         elif isinstance(expr, ir.Scalar):
             return result[0][0]
         else: