New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/TST: Factor out tests that test functionality that every backend implements #1237

Open
cpcloud opened this Issue Nov 22, 2017 · 1 comment

Comments

2 participants
@cpcloud
Member

cpcloud commented Nov 22, 2017

... and make that into one test file that uses a pytest parametrized fixture (https://docs.pytest.org/en/latest/fixture.html#fixture-parametrize). This allows us to use the same set of common-base-functionality tests for every backend.

@cpcloud cpcloud added this to the 0.13 milestone Nov 22, 2017

@kszucs

This comment has been minimized.

Member

kszucs commented Nov 23, 2017

Ideally every backend should be able to compile and execute any ibis expression.

We could maintain an expression => expected result mapping somewhere (e.g. in ibis.expr package) which every backend tries to execute.
In case of unsupported operation the backend should raise the appropriate exception. This way we could even generate an operation support matrix (table) to the docs

@cpcloud cpcloud added this to To do in Refactoring Nov 24, 2017

@kszucs kszucs referenced this issue Dec 8, 2017

Closed

Easier development setup #1255

3 of 3 tasks complete

cpcloud added a commit that referenced this issue Dec 10, 2017

Easier development setup
- docker-compose setup, replaces #1121  - refactored datamgr.py  -
moved test_data_admin and datamgr under testing  - start-all script to
spin up every backends  - ~~skeleton for backend agnostic tests,
related to #1237~~  - updated circleci    - [x] upgrade development
docs  - [x] update appveyor  - [x] make builds pass

Author: Krisztián Szűcs <szucs.krisztian@gmail.com>

Closes #1255 from kszucs/testing and squashes the following commits:

c9238f5 [Krisztián Szűcs] little doc comment
7cbff6e [Krisztián Szűcs] removed testing modifications; little docs update
9c182b2 [Krisztián Szűcs] disable all backend in common client fixture
84935d7 [Krisztián Szűcs] attempt to fix appveyor builds
bbe930f [Krisztián Szűcs] flake8 again
56d8f01 [Krisztián Szűcs] strange trailing whitespace issue
9021ace [Krisztián Szűcs] fix env vars in posgres test_client
68e4851 [Krisztián Szűcs] missed postgres doctest
ada6912 [Krisztián Szűcs] disable sqlite vacuum
4c52f8c [Krisztián Szűcs] trying to fix sqlite analyze error
ea0f15a [Krisztián Szűcs] update env variables in conftest files
a5495a1 [Krisztián Szűcs] flake8
f0b365f [Krisztián Szűcs] common tests
01190e9 [Krisztián Szűcs] modify webhdfs test port
989185d [Krisztián Szűcs] fixed clickhouse column name in tests
5d67117 [Krisztián Szűcs] remove dbug cmd from circleci
3c01458 [Krisztián Szűcs] click un-underscore auto envvar prefix
a43fd79 [Krisztián Szűcs] debug ibis data dir
ebfb8b2 [Krisztián Szűcs] print destination directory during untar
f290dfe [Krisztián Szűcs] start-all
637079b [Krisztián Szűcs] underscore
ca53c89 [Krisztián Szűcs] fixed envvar parsing
4990897 [Krisztián Szűcs] move bigquery conda in requirements files
0cda557 [Krisztián Szűcs] correct download paths
71189f7 [Krisztián Szűcs] update datamgr
f311516 [Krisztián Szűcs] moved testing scripts under testing
7f263e8 [Krisztián Szűcs] fix paths
0418dd9 [Krisztián Szűcs] e
4edd16e [Krisztián Szűcs] e
7ef54e1 [Krisztián Szűcs] dlake8
60082a3 [Krisztián Szűcs] ci

@cpcloud cpcloud modified the milestones: 0.13, 0.14 Feb 14, 2018

@cpcloud cpcloud modified the milestones: 0.14, 0.15 Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment