Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: OmniSci/MapD - Fix reduction for bool #1901

Merged
merged 2 commits into from Aug 2, 2019

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Jul 27, 2019

Fixes #1900

cc @niviksha

@xmnlab
Copy link
Contributor Author

xmnlab commented Jul 27, 2019

cc @ian-r-rose @mpeaton

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmnlab Can you add a mapd-specific translation test for these changes?

@cpcloud cpcloud added this to the Next Feature Release milestone Jul 29, 2019
@cpcloud cpcloud added omnisci bug Incorrect behavior inside of ibis labels Jul 29, 2019
@cpcloud cpcloud self-assigned this Jul 29, 2019
@xmnlab
Copy link
Contributor Author

xmnlab commented Jul 29, 2019

sure! thanks @cpcloud !

@xmnlab
Copy link
Contributor Author

xmnlab commented Aug 2, 2019

@cpcloud tests added!

@cpcloud cpcloud merged commit e740027 into ibis-project:master Aug 2, 2019
@cpcloud cpcloud modified the milestones: Next Feature Release, Next Major Release Aug 26, 2019
@xmnlab xmnlab deleted the fix-reduction-bool branch September 27, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - OmniSci/Mapd: CAST from boolean causes summary() op to fail
2 participants