Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Implement IntervalSub for pandas backend #1951

Merged
merged 1 commit into from Sep 7, 2019

Conversation

toryhaavik
Copy link
Contributor

closes #1490

@toryhaavik toryhaavik added the pandas The pandas backend label Sep 6, 2019
@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #1951 into master will decrease coverage by 1.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1951      +/-   ##
==========================================
- Coverage   87.68%   85.93%   -1.76%     
==========================================
  Files          93       93              
  Lines       16971    16971              
  Branches     2145     2145              
==========================================
- Hits        14881    14584     -297     
- Misses       1681     1972     +291     
- Partials      409      415       +6
Impacted Files Coverage Δ
ibis/pandas/execution/temporal.py 86.04% <ø> (+0.77%) ⬆️
ibis/bigquery/client.py 41.1% <0%> (-53.39%) ⬇️
ibis/bigquery/compiler.py 59.92% <0%> (-37.5%) ⬇️
ibis/bigquery/udf/api.py 80.48% <0%> (-14.64%) ⬇️
ibis/impala/compiler.py 91.23% <0%> (-5.2%) ⬇️
ibis/pandas/dispatch.py 95.45% <0%> (-4.55%) ⬇️
ibis/pandas/client.py 85.54% <0%> (-3.47%) ⬇️
ibis/bigquery/api.py 63.33% <0%> (-3.34%) ⬇️
ibis/omniscidb/client.py 58.33% <0%> (-2.23%) ⬇️
ibis/common/geospatial.py 80.23% <0%> (-1.17%) ⬇️
... and 6 more

Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmnlab xmnlab merged commit ec19061 into ibis-project:master Sep 7, 2019
costrouc pushed a commit to costrouc/ibis that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pandas The pandas backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Interval arithmetic on one or more backends
2 participants