CLN: Remove overcomplicatted logging #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
added
refactor
|
sure can you add a release note as this is technically public. |
Closed
|
@datapythonista seems like this is ready for merge. |
jreback
approved these changes
Sep 8, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some backends implement
Client.log, which doesn't seem useful at all. I guess the original reason was to be able to overwrite the method, so the logging could be replaced. I don't thinkClientis subclassed for any of the backends that provide thelogmethod. And also, the provided implementation of the logging usesoptions.verbose_log, which can be set to change the logging in an easier way than overwritting the method.Removing those
logmethods here, which are inconsistent among backends, don't provided any feature, and polute the publicClientAPI.