Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add contributing style guide for docs #7094

Closed
1 task done
lostmygithubaccount opened this issue Sep 7, 2023 · 11 comments · Fixed by #8092
Closed
1 task done

docs: add contributing style guide for docs #7094

lostmygithubaccount opened this issue Sep 7, 2023 · 11 comments · Fixed by #8092
Assignees
Labels
docs Documentation related issues or PRs

Comments

@lostmygithubaccount
Copy link
Member

Please describe the issue

we should add a style guide (and perhaps general guide) for contributing to documentation

if you have strong opinions on style or anything, feel free to weigh in here

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lostmygithubaccount lostmygithubaccount added the docs Documentation related issues or PRs label Sep 7, 2023
@lostmygithubaccount lostmygithubaccount self-assigned this Sep 7, 2023
@cpcloud
Copy link
Member

cpcloud commented Sep 9, 2023

Some of my opinions:

  • wrap long prose strings (somewhere between 80-90 characters, vim's default wrapping seems fine)
  • any computations that can't or shouldn't be done again should use freeze: auto in the YAML front matter, and never freeze: true. freeze: true results in silently stale pages. freeze: auto will cause CI to fail if computations occur because a page has not been frozen locally and pushed to a PR.
  • format code blocks with black or as close as possible to it
  • freeze: auto should always be used per page unless there's a good reason to use it for a collection of pages (blog posts, for example)
  • prefer <language> instead of {.<language>} in triple-backtick-quoted code text

so instead of

```{.python}
# code
```

we do

```python
# code
```

@gforsyth
Copy link
Member

As per #6957 with an overwhelming 5 votes cast, always refer to the library name as Ibis in prose.

@gforsyth
Copy link
Member

wrap long prose strings (somewhere between 80-90 characters, vim's default wrapping seems fine)

Very strong agree on this. It makes diffs on prose and reviewing prose MUCH cleaner

@gforsyth
Copy link
Member

Other opinions:

  • No jupyter notebooks (in ipynb form) allowed -- they can be used to author something but only the converted qmd file should be committed.
  • Avoid the passive voice. Either Ibis does something or the user does something (or a particular backend does something). Hot take: if the passive voice seems like the best way to describe something, we probably need to redesign the API / code in question, because it is clearly riddled with side-effects.
  • Try to avoid using simply / simple, obviously, just, when describing things that Ibis makes easier. Either the simplicity is self-evident or it isn't.
  • LLMs do not write well, they write correctly, but it's doggerel. (this one probably doesn't belong in the style guide)

@lostmygithubaccount
Copy link
Member Author

Try to avoid using simply / simple, obviously, just, when describing things that Ibis makes easier. Either the simplicity is self-evident or it isn't.

huge +1, I am personally very bad at this (and similar words), please do call it out!

wrap long prose strings (somewhere between 80-90 characters, vim's default wrapping seems fine)

I'm actually against this...unless this is something a formatter handles? otherwise I find this makes it very hard to edit (dealing w/ where to place newlines)

@cpcloud
Copy link
Member

cpcloud commented Sep 11, 2023

I'm actually against this...unless this is something a formatter handles? otherwise I find this makes it very hard to edit (dealing w/ where to place newlines)

Can you elaborate a bit? Most editors have "hard wrap" functionality that should handle this.

@cpcloud
Copy link
Member

cpcloud commented Sep 11, 2023

Standard markdown doesn't render single linebreaks, while GitHub Flavored Markdown does. Perhaps that is confusing the issue?

@lostmygithubaccount
Copy link
Member Author

I use vim/nvim and it does wrap lines for me, but doesn't insert linebreaks. if this is a case of my just doing something wrong then I'm happy to conform

@gforsyth
Copy link
Member

I use vim/nvim and it does wrap lines for me, but doesn't insert linebreaks. if this is a case of my just doing something wrong then I'm happy to conform

You can use gq and then a movement to wrap. gqG will linewrap the whole document.

@cpcloud
Copy link
Member

cpcloud commented Sep 11, 2023

I believe you have to use gw in recent versions of neovim 😬

@gforsyth
Copy link
Member

that seems like a weird choice, but ok!

gforsyth added a commit that referenced this issue Jan 26, 2024
## Description of changes

Adding a first version of our unwritten style guide for prose and
documentation.

## Issues closed

Resolves #7094
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants