bug(bigquery): rank with windowed order by with multiple columns lists columns in the wrong order (regression in 7.2.0, working in 7.1.0)

[tswast]

What happened?

import ibis
bq = ibis.bigquery.connect(project_id="swast-scratch")
import pandas
df = pandas.DataFrame({"bool_col": [True, False, False, None, True]})
table = ibis.memtable(df)
window = ibis.window(
    order_by=[
        ibis.asc(table["bool_col"].isnull()),
        ibis.asc(table["bool_col"]),
    ],
)
rank = table["bool_col"].rank().over(window)
expr = table.select([
    rank, table["bool_col"]
])
bq.execute(expr)
print(bq.compile(expr))

This works fine in 7.1.0:

In [2]: bq.execute(expr)
Out[2]: 
   MinRank() bool_col
0          0    False
1          4     None
2          0    False
3          2     True
4          2     True

In [3]: print(bq.compile(expr))
SELECT
  (
    rank() OVER (ORDER BY t0.`bool_col` IS NULL ASC, t0.`bool_col` ASC) - 1
  ) AS `MinRank`,
  t0.`bool_col`
FROM swast-scratch._63cfa399614a54153cc386c27d6c0c6fdb249f9e._ibis_pandas_memtable_45ft72ov35gvleackhzyaenloi AS t0

In 7.2.0, the IS NULL column expression appears second, which changes where NULL values appear in the ranking:

In [3]: bq.execute(expr)
Out[3]: 
   MinRank() bool_col
0          3     True
1          1    False
2          1    False
3          0     None
4          3     True

SELECT
  (
    -- IS NULL column expression should appear first. :-(
    rank() OVER (ORDER BY t0.`bool_col` ASC, t0.`bool_col` IS NULL ASC) - 1
  ) AS `MinRank`,
  t0.`bool_col`
FROM swast-scratch._63cfa399614a54153cc386c27d6c0c6fdb249f9e.ibis_pandas_memtable_ctis2cnl65dplgtuqh7eqozqwy AS t0

What version of ibis are you using?

7.2.0

What backend(s) are you using, if any?

BigQuery

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[cpcloud]

@tswast Thanks for the issue!

I'm working on a fix that hopefully will be up shortly!

[tswast]

Thanks @cpcloud !

[tswast]

Looks like this might still be broken in ibis 8.0.0. The nlargest/nsmallest tests are still failing in googleapis/python-bigquery-dataframes#277

[tswast]

Looks like this might still be broken in ibis 8.0.0. The nlargest/nsmallest tests are still failing in googleapis/python-bigquery-dataframes#277

Nevermind, we were doing column.rank() instead of ibis.rank() for some reason, which was overriding the window a bit.