feat(api): expose common types in the top-level ibis namespace
#9008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrist
commented
Apr 18, 2024
| @@ -51,6 +54,15 @@ | |||
| from ibis.expr.schema import SchemaLike | |||
|
|
|||
| __all__ = ( | |||
There was a problem hiding this comment.
I ran :sort on this list in vim, which is why there's a bunch of extra movement here.
Turns out we were already exporting Expr and Schema types (but no others), but these were buried in the __all__ list before :).
cpcloud
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Table,Column,Scalar,Value, andDeferredto the top-levelibisnamespace. These are mostly useful for downstream users consuming the ibis api (either type-annotating their code, or usingisinstancechecks).Fixes #8717.