Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): expose common types in the top-level ibis namespace #9008

Merged
merged 1 commit into from
Apr 19, 2024
Merged

feat(api): expose common types in the top-level ibis namespace #9008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
54 changes: 31 additions & 23 deletions ibis/expr/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,14 @@
from ibis.expr.schema import Schema
from ibis.expr.sql import parse_sql, to_sql
from ibis.expr.types import (
Column,
DateValue,
Expr,
Scalar,
Table,
TimestampValue,
TimeValue,
Value,
array,
literal,
map,
Expand All @@ -51,6 +54,15 @@
from ibis.expr.schema import SchemaLike

__all__ = (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran :sort on this list in vim, which is why there's a bunch of extra movement here.

Turns out we were already exporting Expr and Schema types (but no others), but these were buried in the __all__ list before :).

"Column",
"Deferred",
"Expr",
"NA",
"Scalar",
"Schema",
"Table",
"Value",
"_",
"aggregate",
"and_",
"array",
Expand All @@ -59,20 +71,17 @@
"coalesce",
"connect",
"cross_join",
"cumulative_window",
"cume_dist",
"rank",
"ntile",
"dense_rank",
"percent_rank",
"cumulative_window",
"date",
"desc",
"decompile",
"deferred",
"dense_rank",
"desc",
"difference",
"dtype",
"e",
"Expr",
"following",
"geo_area",
"geo_as_binary",
"geo_as_ewkb",
Expand All @@ -83,38 +92,38 @@
"geo_centroid",
"geo_contains",
"geo_contains_properly",
"geo_covers",
"geo_covered_by",
"geo_covers",
"geo_crosses",
"geo_d_fully_within",
"geo_disjoint",
"geo_difference",
"geo_d_within",
"geo_difference",
"geo_disjoint",
"geo_distance",
"geo_end_point",
"geo_envelope",
"geo_equals",
"geo_geometry_n",
"geo_geometry_type",
"geo_intersection",
"geo_intersects",
"geo_is_valid",
"geo_length",
"geo_line_locate_point",
"geo_line_merge",
"geo_line_substring",
"geo_ordering_equals",
"geo_overlaps",
"geo_touches",
"geo_distance",
"geo_end_point",
"geo_length",
"geo_max_distance",
"geo_n_points",
"geo_n_rings",
"geo_ordering_equals",
"geo_overlaps",
"geo_perimeter",
"geo_point",
"geo_point_n",
"geo_simplify",
"geo_srid",
"geo_start_point",
"geo_touches",
"geo_transform",
"geo_unary_union",
"geo_union",
Expand All @@ -137,43 +146,42 @@
"literal",
"map",
"memtable",
"NA",
"negate",
"now",
"ntile",
"null",
"or_",
"param",
"parse_sql",
"percent_rank",
"pi",
"preceding",
"random",
"range",
"range_window",
"rank",
"read_csv",
"read_delta",
"read_json",
"read_parquet",
"row_number",
"rows_window",
"schema",
"Schema",
"selectors",
"set_backend",
"struct",
"to_sql",
"table",
"today",
"time",
"timestamp",
"to_sql",
"today",
"trailing_range_window",
"trailing_window",
"union",
"uuid",
"watermark",
"where",
"window",
"preceding",
"following",
"_",
)


Expand Down