New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fill out more pandas backend operations #1423

Closed
wants to merge 47 commits into
base: master
from

Conversation

Projects
2 participants
@cpcloud
Member

cpcloud commented Apr 14, 2018

Also fixes an xfailed test because of postgres

@cpcloud cpcloud added this to To do in Pandas via automation Apr 14, 2018

@cpcloud cpcloud added this to the 0.14 milestone Apr 14, 2018

@cpcloud cpcloud self-assigned this Apr 14, 2018

@cpcloud cpcloud changed the title from ENH: Add scalar math functions to pandas to ENH: Fill out more pandas backend operations Apr 14, 2018

@cpcloud cpcloud force-pushed the cpcloud:pandas-operations branch 4 times, most recently from 920be04 to 78afb7e Apr 14, 2018

@cpcloud cpcloud force-pushed the cpcloud:pandas-operations branch from 78afb7e to 2feccb9 Apr 23, 2018

@cpcloud cpcloud force-pushed the cpcloud:pandas-operations branch 2 times, most recently from cabf29f to bfc4622 May 11, 2018

@@ -164,7 +181,11 @@ def schema_from_table(table, schema=None):
if name in schema:
dtype = dt.dtype(schema[name])
else:
dtype = dt.dtype(column.type, nullable=column.nullable)
dtype = dt.dtype(

This comment has been minimized.

@kszucs

kszucs May 15, 2018

Member

Ohh, this is tricky!

@kszucs

kszucs approved these changes May 15, 2018 edited

Like conda would say:

I just wanted to let you know that I reviewed your changes and found it was in an excellent condition.

Nice to see that all tests are gaining weight.

@cpcloud

This comment has been minimized.

Member

cpcloud commented May 15, 2018

@kszucs Thanks for the review, yeah the all tests are definitely exposing edge cases.

@cpcloud cpcloud force-pushed the cpcloud:pandas-operations branch from 4f9dc33 to 90038b8 May 15, 2018

@cpcloud cpcloud force-pushed the cpcloud:pandas-operations branch from c62f8aa to c2301b3 May 16, 2018

@cpcloud cpcloud force-pushed the cpcloud:pandas-operations branch from 69bddf3 to 5ec6318 May 18, 2018

@cpcloud cpcloud closed this in 762b98d May 18, 2018

Pandas automation moved this from To do to Done May 18, 2018

@cpcloud cpcloud deleted the cpcloud:pandas-operations branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment