ENH: Fill out more pandas backend operations #1423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
tests
cpcloud
changed the title
cpcloud
force-pushed
the
pandas-operations
branch
4 times, most recently
from
920be04
to
78afb7e
Compare
cpcloud
force-pushed
the
pandas-operations
branch
from
78afb7e
to
2feccb9
Compare
cpcloud
force-pushed
the
pandas-operations
branch
2 times, most recently
from
cabf29f
to
bfc4622
Compare
kszucs
reviewed
May 15, 2018
| @@ -164,7 +181,11 @@ def schema_from_table(table, schema=None): | |||
| if name in schema: | |||
| dtype = dt.dtype(schema[name]) | |||
| else: | |||
| dtype = dt.dtype(column.type, nullable=column.nullable) | |||
| dtype = dt.dtype( | |||
kszucs
approved these changes
May 15, 2018
|
@kszucs Thanks for the review, yeah the |
cpcloud
force-pushed
the
pandas-operations
branch
from
4f9dc33
to
90038b8
Compare
cpcloud
force-pushed
the
pandas-operations
branch
from
c62f8aa
to
c2301b3
Compare
cpcloud
force-pushed
the
pandas-operations
branch
from
69bddf3
to
5ec6318
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes an xfailed test because of postgres