Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backends/mssql): Add backend support for Microsoft Sql Server #4879

Merged
merged 1 commit into from Nov 23, 2022

Conversation

oneextrafact
Copy link

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2022

Test Results

       41 files         41 suites   1h 41m 23s ⏱️
11 615 tests   8 857 ✔️ 2 758 💤 0
41 502 runs  31 515 ✔️ 9 987 💤 0

Results for commit a5b0eb4.

♻️ This comment has been updated with latest results.

@cpcloud cpcloud added this to the 4.0.0 milestone Nov 20, 2022
@cpcloud cpcloud added the mssql The Microsoft SQL Server backend label Nov 20, 2022
@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #4879 (226d4cb) into master (df91515) will decrease coverage by 0.84%.
The diff coverage is 56.79%.

❗ Current head 226d4cb differs from pull request most recent head 29c5f74. Consider uploading reports for the commit 29c5f74 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4879      +/-   ##
==========================================
- Coverage   92.86%   92.02%   -0.85%     
==========================================
  Files         189      193       +4     
  Lines       21654    21734      +80     
  Branches     3004     3008       +4     
==========================================
- Hits        20110    20001     -109     
- Misses       1130     1318     +188     
- Partials      414      415       +1     
Impacted Files Coverage Δ
ibis/backends/mssql/datatypes.py 0.00% <0.00%> (ø)
ibis/backends/mssql/registry.py 47.61% <47.61%> (ø)
ibis/backends/mssql/__init__.py 69.23% <69.23%> (ø)
ibis/backends/conftest.py 91.72% <100.00%> (ø)
ibis/backends/mssql/compiler.py 100.00% <100.00%> (ø)
ibis/backends/snowflake/registry.py 0.00% <0.00%> (-93.94%) ⬇️
ibis/backends/snowflake/datatypes.py 0.00% <0.00%> (-89.40%) ⬇️
ibis/backends/snowflake/__init__.py 4.61% <0.00%> (-84.62%) ⬇️
ibis/backends/sqlite/__init__.py 92.20% <0.00%> (-3.90%) ⬇️
ibis/backends/duckdb/__init__.py 82.38% <0.00%> (-1.56%) ⬇️
... and 2 more

@cpcloud cpcloud force-pushed the feature-mssql-backend branch 9 times, most recently from b6f7c66 to 56c0180 Compare November 22, 2022 19:07
@cpcloud cpcloud requested a review from kszucs November 22, 2022 19:08
@cpcloud cpcloud marked this pull request as ready for review November 22, 2022 19:08
@cpcloud
Copy link
Member

cpcloud commented Nov 22, 2022

This is now passing CI, and is ready for review.

@cpcloud cpcloud added the feature Features or general enhancements label Nov 22, 2022
@cpcloud
Copy link
Member

cpcloud commented Nov 22, 2022

@oneextrafact It looks like we're all green now! Let me know if you're still having trouble running the tests.

@cpcloud cpcloud merged commit fc39323 into ibis-project:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements mssql The Microsoft SQL Server backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants