Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(duckdb): clean up temp view junk when using memtables in create_table #9107

Merged
merged 2 commits into from
May 2, 2024
Merged

fix(duckdb): clean up temp view junk when using memtables in create_table #9107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d57a739
fix(duckdb): clean up temporary views created from memtables during `…
cpcloud May 2, 2024
9368bb4
docs(getting-started): remove the need for the double connect to avoi…
cpcloud May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/tutorials/getting_started.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ con.create_table(
You can now see the example dataset copied over to the database:

```{python}
con = ibis.connect("duckdb://penguins.ddb")
con.list_tables()
```

Expand Down
6 changes: 6 additions & 0 deletions ibis/backends/duckdb/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,12 @@ def create_table(
if temp:
properties.append(sge.TemporaryProperty())

temp_memtable_view = None

if obj is not None:
if not isinstance(obj, ir.Expr):
table = ibis.memtable(obj)
temp_memtable_view = table.op().name
else:
table = obj

Expand Down Expand Up @@ -248,6 +251,9 @@ def create_table(
).sql(self.name)
)

if temp_memtable_view is not None:
self.con.unregister(temp_memtable_view)

return self.table(name, database=database)

def _load_into_cache(self, name, expr):
Expand Down
Loading