Fix resumeTransaction always being forced when tx sync is inactive #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sponsor
Member
nielsm5
commented
Jul 27, 2022
•
nielsm5
commented
- Disable streaming xslt when attribute streamingActive is set to false
- Improve error handling when XsltSender cannot parse XML (and the ExceptionCatchingFilter is never called)
nielsm5
commented
Aug 1, 2022
| public void resumeTransaction() { | ||
| resumeTransaction(false); | ||
| } | ||
| public void resumeTransaction(boolean force) { | ||
| if (suspended || force) { | ||
| log.debug("resumeTransaction() resuming transaction of parent thread [{}], current thread [{}]", ()->parentThread.getName(), ()->Thread.currentThread().getName()); | ||
| if (!force || !TransactionSynchronizationManager.isSynchronizationActive()) { |
nielsm5
changed the title
gvanbrakel
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.