Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream *arr configuration #155

Open
ambroisie opened this issue Feb 1, 2024 · 3 comments
Open

Upstream *arr configuration #155

ambroisie opened this issue Feb 1, 2024 · 3 comments

Comments

@ambroisie
Copy link

ambroisie commented Feb 1, 2024

Quoting from the README:

One important goal of SHB is to be the smallest amount of code above what is available in nixpkgs. It should be the minimum necessary to make packages available there conform with the contracts. This way, there are less chance of breakage when nixpkgs gets updated.

However, it looks like the *arr configuration modules go against that ethos:

  • the XML generator could be upstreamed to nixpkgs.
  • the various configuration options could be upstreamed to each of the *arr modules.
@ambroisie
Copy link
Author

Here's an example of a PR that could be improved by using those options directly in nixpkgs: NixOS/nixpkgs#285119.

@ibizaman
Copy link
Owner

ibizaman commented Feb 2, 2024

@ambroisie oh how I wholeheartedly agree! That is my intention but I didn't find the time to do that yet. I should probably clarify that I intend this ethos to be quite elastic. First a growing phase while I'm testing and then a shrinking phase when code gets upstreamed.

I'm focusing right now on Nextcloud and everything around it. I'm pretty satisfied with the declarative LDAP and SSO setup so far. Now, I'm working on the backup part. I do have backup working actually, but I want to make it a real SHB block with a contract an all. Like for the new SSL block.

That being said, I'd be very happy to upstream this first if you would benefit from it?

@ambroisie
Copy link
Author

I would probably make use of it if upstreamed, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants