nixos/tests/prometheus-exporters: add exportarr-sonarr test #285119
Conversation
Stunkymonkey
force-pushed
the
nixos-expoartarr-sonarr-test
branch
from
def5c1a
to
6ef5899
Compare
Stunkymonkey
force-pushed
the
nixos-expoartarr-sonarr-test
branch
from
6ef5899
to
4851b2b
Compare
sorry should have assigned it to you when the PR is ready. please review now. |
| services.sonarr.enable = true; | ||
| systemd.services.sonarr.serviceConfig.ExecStartPre = | ||
| let | ||
| sonarr_config = pkgs.writeText "config.xml" '' |
There was a problem hiding this comment.
should I use builtins.toXML or is this fine?
There was a problem hiding this comment.
Drive-by comment: it might be nice to make (some) of those configuration options part of the *arr modules? I'm mainly thinking about the port(s), log level, bind address, and API key.
Though I'm not sure how the declarative options and web-ui options would mesh.
Feel free to dismiss this, I'm just curious as I never really looked into the config files for this suite of software.
There was a problem hiding this comment.
that is a nice idea. I would suggest to have this in a separate MR. might be relevant for multiple *arr services.
I would be very interested to supply the API-Key for my config. hate the current manual clicking setup.
|
@fpletz can we merge this? |
Description of changes
enhanced the test to not only test for http response, but also valid content.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.