feat(analytics): add analytics id function #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonsmh
changed the title
pidupuis
approved these changes
Jan 17, 2017
iblh
reviewed
Jan 17, 2017
| # Analytics Systems | ||
| # Available value: | ||
| # baidu | google | ||
| analytics: |
There was a problem hiding this comment.
delete use field.
set null value of baidu_id & google_id
iblh
requested changes
Jan 17, 2017
| @@ -95,6 +95,29 @@ | |||
| } | |||
| </script> | |||
|
|
|||
| <% if(theme.analytics.use === 'baidu') { %> | |||
There was a problem hiding this comment.
change this judgement.
Template:
<% if(theme.analytics.baidu_id){ %>
baidu analytics code
<% } %>
|
Done. Please review. Thx. |
iblh
approved these changes
Jan 17, 2017
|
Alright, markdown docs |
iblh
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to put the
canarybranch as the target for your pull request.What kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")