Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contributing): update master from canary #163

Merged
merged 2 commits into from
Jan 21, 2017
Merged

Conversation

pidupuis
Copy link
Collaborator

@pidupuis pidupuis commented Jan 21, 2017

New PR (even targeting canary branch) uses contributing.json from master branch so we are sill blocked by rules like "subject_must_be_longer_than": 4 and "body_must_include_screenshot": ["html", "css"]. Also, branch names are not checked.

Besides, PR targeting master does not use templates.

No verification steps.

@ghost
Copy link

ghost commented Jan 21, 2017

Your pull request doesn't follow our guidelines. Please fix the following:

  • Pull request description must include verification steps (?)

Click here for details.

Thank you! 🙏

This comment was made by GitMagic – Magically enforcing your contribution guidelines.

@ghost
Copy link

ghost commented Jan 21, 2017

Thank you, the title and description now looks good! :bowtie:

@pidupuis
Copy link
Collaborator Author

@viosey @cubesky @neoFelhz
Please need one review to merge 🐼

Copy link
Collaborator

@cubesky cubesky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@iblh iblh merged commit 9f9e430 into master Jan 21, 2017
@pidupuis pidupuis deleted the chore/contributing branch January 22, 2017 15:23
@iblh iblh mentioned this pull request Jan 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants