feat(sidebar): add support for customize sidebar #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove I'm Feeling Lucky - Support for sidebar customize - Change the config file
cubesky
approved these changes
Jan 21, 2017
pidupuis
requested changes
Jan 21, 2017
| </li> | ||
| --> | ||
| <% if(theme.sidebar.homepage === true) { %> | ||
| <li id="sidebar-first-li"> |
There was a problem hiding this comment.
- Please fix indentation (remove 4 spaces before lines 18, 19 and 20)
| <% if(theme.sidebar.archives === true) { %> | ||
| <li class="dropdown"> | ||
| <a href="#" class="ripple-effect dropdown-toggle" data-toggle="dropdown"> | ||
| <i class="material-icons sidebar-material-icons"><%= theme.sidebar.archive.icon %></i> |
There was a problem hiding this comment.
- It should be
theme.sidebar.archives.icon(you forgot an 's') - Please surround this line with the following condition:
if(theme.sidebar.archives.icon){
|
|
||
| <!-- Categories --> | ||
| <% if(theme.sidebar_categories === true) { %> | ||
| <% if(theme.sidebar.categories === true) { %> | ||
| <li class="dropdown"> | ||
| <a href="#" class="ripple-effect dropdown-toggle" data-toggle="dropdown"> | ||
| <i class="material-icons sidebar-material-icons">chrome_reader_mode</i> |
There was a problem hiding this comment.
- You seem to have forgotten to use the icon from the configuration like
<%= theme.sidebar.categories.icon %> - And then surround this line with the following condition:
if(theme.sidebar.categories.icon){
| <a href="<%= theme.dropdown[i].link %>" target="_blank" title="<%= i %>"> | ||
| <i class="material-icons sidebar-material-icons sidebar-indent-left1pc-element"><%= theme.dropdown[i].icon %></i> | ||
| <a href="<%= theme.sidebar.dropdown[i].link %>" target="_blank" title="<%= i %>"> | ||
| <i class="material-icons sidebar-material-icons sidebar-indent-left1pc-element"><%= theme.sidebar.dropdown[i].icon %></i> |
There was a problem hiding this comment.
- Please surround this line with the following condition:
if(theme.sidebar.dropdown[i].icon){
|
@pidupuis OK，I will fix themw. |
- add a check use 'if' whether user do configure icon - add some missed lines (about categories icon)
|
@pidupuis Now I push a new commit to fix them,please review them again(And sorry for my carelessness) |
pidupuis
approved these changes
Jan 22, 2017
9 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")
Description
Add support for sidebar customize.
You can customize your sidebar icons in config file now.
(I remove the I'm Feeling Lucky item as well)
Verification steps