Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#336) #337

Merged
merged 1 commit into from
May 4, 2017
Merged

fix(#336) #337

merged 1 commit into from
May 4, 2017

Conversation

neoFelhz
Copy link
Collaborator

@neoFelhz neoFelhz commented May 3, 2017

Contributing rules

  • Fork the repo and create your branch from canary. Then be sure to put the canary branch as the target for your pull request.
  • Please be sure to follow the contributing guidelines, especially for commit message
  • Remove the Contributing rules part from this description
  • Fill out the other parts from this description

If you don't do so, we might change your pull request's title and using squash to merge your changed.

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

No description.


Verification steps

No verification steps.

@EYHN
Copy link
Contributor

EYHN commented May 3, 2017

玄学

@Halyul
Copy link
Contributor

Halyul commented May 3, 2017

@neoFelhz 玄学修复2333

@neoFelhz neoFelhz requested review from cubesky and iblh May 3, 2017 10:30
@neoFelhz
Copy link
Collaborator Author

neoFelhz commented May 3, 2017

@EYHN @Halyul <a> 标签里,换行会被当成空格的。这个我和 @viosey 在写 copyright_since 时是领教过的。法国小哥也是这么修复 footer_sns icon 的。

@EYHN
Copy link
Contributor

EYHN commented May 3, 2017

通过 text-decoration 属性解决似乎更加合理

text-decoration: none;

@Halyul
Copy link
Contributor

Halyul commented May 3, 2017

@neoFelhz 我同意@EYHN 的方法🙄

@cubesky
Copy link
Collaborator

cubesky commented May 3, 2017

@EYHN 上次我这么修被close..

@neoFelhz
Copy link
Collaborator Author

neoFelhz commented May 3, 2017

@EYHN @Halyul
text-decoration 不能根治空格的存在,只能让其不显示。

@EYHN
Copy link
Contributor

EYHN commented May 3, 2017

我试了一下发现在 a 标签上添加 display: inline-block; 样式也可以解决这个问题

@EYHN
Copy link
Contributor

EYHN commented May 3, 2017

逻辑上 text-decoration: none;display: inline-block; 都是需要的

@neoFelhz neoFelhz merged commit ce2c515 into canary May 4, 2017
@neoFelhz neoFelhz deleted the fix/sidebar/footer branch May 4, 2017 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants