Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/refactor(path): fix subdir error & refactor url concatenation #423

Merged
merged 2 commits into from Jul 2, 2017
Merged

fix/refactor(path): fix subdir error & refactor url concatenation #423

merged 2 commits into from Jul 2, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 1, 2017

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

No description.


Verification steps

No verification steps.

 - Use "url_for(path)" instead of "config.root + path" (ref: https://hexo.io/docs/helpers.html ).
 - Fix 404 error when site is in a subdirectory.
Closes #420
@neoFelhz
Copy link
Collaborator

neoFelhz commented Jul 2, 2017

@bloodtox3710
Please remove execution permissions

@neoFelhz
Copy link
Collaborator

neoFelhz commented Jul 2, 2017

@bloodtox3710 Origin files only need 100644

 - remove unnecessary execution permissions.
@ghost
Copy link
Author

ghost commented Jul 2, 2017

@neoFelhz
Already fixed. Thanks for your friendly reminder.

@neoFelhz neoFelhz merged commit e49bdee into iblh:canary Jul 2, 2017
@neoFelhz neoFelhz mentioned this pull request Jul 3, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant