Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(valine): attribute configurations do not take effect #678

Merged
merged 1 commit into from
Jul 30, 2018
Merged

fix(valine): attribute configurations do not take effect #678

merged 1 commit into from
Jul 30, 2018

Conversation

LyonUp
Copy link
Contributor

@LyonUp LyonUp commented Jul 7, 2018

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

无法设置 valine 评论的 valine_notify/valine_verify 属性为 true ,因为在 javascript 中:

'true' == true; // return false

Verification steps

在主题配置文件中:

comment:
    use: valine
    valine_notify: true # valine mail notify (true/false) https://github.com/xCss/Valine/wiki
    valine_verify: true # valine verify code (true/false)

@neoFelhz neoFelhz merged commit 841043c into iblh:canary Jul 30, 2018
@LyonUp LyonUp deleted the fix/comment/valine branch July 31, 2018 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants