This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
Debug without having to package or install #287
Merged
+321
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstone1
reviewed
Nov 5, 2018
| } | ||
|
|
||
| // tslint:disable-next-line no-empty | ||
| public dispose(): void { | ||
| } | ||
|
|
||
| private getNewVersion(): string { | ||
| const date: Date = new Date(); | ||
| return `${this.PREFIX}-${date.getHours()}${date.getMinutes()}${date.getDate()}${date.getMonth()}${date.getFullYear()}`; |
There was a problem hiding this comment.
This should be YYYYMMDDHHMM so it can be easily sorted in chronological order 😉
There was a problem hiding this comment.
Also, for consistency suggest you ensure the number of digits (12 in total) for each field.
sstone1
suggested changes
Nov 5, 2018
Automatically packages and installs a smart contract Also excluded images from the package contributes to #232 Signed-off-by: Caroline Church <caroline.church@uk.ibm.com>
Signed-off-by: Caroline Church <caroline.church@uk.ibm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically packages and installs a smart contract
Also excluded images from the package
contributes to #232
Signed-off-by: Caroline Church caroline.church@uk.ibm.com