Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Update wallet for connecting #428

Closed
cazfletch opened this issue Dec 19, 2018 · 6 comments · Fixed by #475
Closed

Update wallet for connecting #428

cazfletch opened this issue Dec 19, 2018 · 6 comments · Fixed by #475

Comments

@cazfletch
Copy link
Contributor

Currently the extension asks the user for a cert and private key. It does not allow users to use an existing wallet, which means that it's confusing for a user to use with samples such as commercial paper that instructs users to create a wallet.

Currently the extension uses the in-memory wallet. Under the covers. A proposal would be to change to using a file system wallet. This way a user could point the extension at an existing wallet to use for that connection.

We would create the wallets on the file system where we keep other data if the user wasn't using their own wallet

The other advantage is that when developing applications they could point their application at the wallet used in a configuration.

@EdMoffatt
Copy link
Contributor

A few things to do on this one:

  • Have a call with Varad and talk about how IBP is using "Wallet". From their designs, it looks to be something slightly different from what we're describing here.
  • Agree a first implementation to help the Engagement team out at Think.

@cazfletch
Copy link
Contributor Author

Proposal is that each connection has a wallet with the identities in for that connection.

If you only had one wallet for all connections how would you know which identity was for which connection?

@sstone1
Copy link
Contributor

sstone1 commented Jan 7, 2019

@EdMoffatt @Tobias-Hunter @caroline-church the SDK allows you to use a single wallet across multiple gateway connections; IMO we should think about reflecting this in the developer tools as well. With the refocusing on peers rather than "networks", it is more likely that developers will use the same identities to connect to multiple peers.

Maybe the default is "one connection, one wallet" but you can have "two connections, one wallet" if you want to do the above?

@cazfletch
Copy link
Contributor Author

i think when we do the refocusing on the peers we should then do the two connections, one wallet but until then i think we should have one connection one wallet

@EdMoffatt
Copy link
Contributor

I think all these suggestions are spot on :)

@Tobias-Hunter
Copy link

Tried to capture everything that we talked about @heatherlp - once you have a first version of the implementation, if we could go through it that'd be great!

Command palette flows:
screenshot 2019-01-09 at 10 05 01

Blockchain connections pannel:
screenshot 2019-01-09 at 09 56 58

Any questions please lemme know! ✌🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants