As a developer I can manage my wallets

[cazfletch]

Let's use this epic to track the UI changes required for managing wallets, and for discussion on how we link those with gateways.

[EdMoffatt]

Did a first sketch for wallets, and got some feedback + questions on Slack - posting it all up here for reference (and to invite further input from GitHub folks!):

Some of my explanation of my thoughts:

What do you think to the idea of adding a “vscode_wallet”? I’d figured

1. It’s there by default, and contains ID(s) for the local_fabric
2. Whenever we previously had the option of “filesystem wallet or not filesystem wallet”, it becomes more “provide a specific filesystem wallet, or add it to this generic vscode one that definitely exists”?
   This is because I don’t think showing IDs as children of gateways makes sense anymore, therefore if the user isn’t providing a path to the filesystem wallet, we still need to put them somewhere and show them in the UI so they can be added to, deleted etc.

I guess the alternative would be that if they don’t provide an explicit filesystem wallet, we create a wallet that is like “gateway_name_wallet”.

I quite like the idea of being able to add a gateway without specifying a wallet. I don’t think there’s any actual utility to that, but something about “you make gateways, you make wallets, and for convenience you can associate wallets with gateways” feels logical to me, and having the step of needing to pick/add a wallet when you add a gateway doesn’t quite fit that model

Caroline:

i think it makes sense, as now wallets aren't tied to gateways then calling it local fabric wallet doesn't make sense anymore as you could put extra id's in their that arent local fabric ones

Heather:

regarding initial thoughts, I like what I can see so far 🙂 right now I can only thing of 1) whether we’re going to allow the user to see the wallets in their user settings (like we do for gateways) 2) will “edit wallet” be a thing? or if they want to use a different wallet path, they just need to delete and create a new one?
3) this is just rambling thoughts: I might need to treat the in-house local_fabric wallet as a different thing? like we do the local_fabric gateway, because we wouldn’t want to be able to delete it? or in fact, edit the local_fabric wallet path or “disassociate it”. I’ve finished the “create a new identity from a CA” code, which adds a new identity to the local_fabric wallet, which right now can only be removed upon teardown. So I guess I’d need to make sure the local_fabric wallet and gateway are inherently associated, and by tearing down local_fabric, I clear the wallet too? (like we do right now), or we change that behaviour, and allow the user to delete identities

[EdMoffatt]

Attaching command palette flows to the Epic (I'll go attach them to related sub-issues too!)

[heatherlp]

Currently thinking:

• create wallet registry (done in New wallet registry (closes #698) #702 )
• create new wallet panel (As a developer, I want to see my wallets #704)
• "Add new wallet" command ("Add new wallet" command #705 )
• separate link between gateways and wallets (Separate wallets and gateways #718)
• Complete Add wallet command flow (Fix "add wallet" command flow #750) and (As a developer, I can create/add/import a wallet #658)
• "Associate wallet" command (As a developer, I can associate a wallet with a gateway #758)
• Fix edit gateway command to remove '+ Connection Profile' from the tree (Fix edit gateway command #762)
• New "Edit wallet" command to match edit gateway functionality (New Edit Wallet command #764)
• Remove wallet (As a developer, I can delete a wallet #759 ) and delete identity (As a developer i can delete identities from a wallet #690 )
• Fix and rename "export connection details" command to export connection profile (Refactor export connection details to export connection profile #766)
• integration tests
• Fix the // TODO: edit to use different identities in wallet comment in the test templates
• merge into master 👿
• readMe updates for new view and commands (Update README for new wallets feature #830)
• close off Need to remember MSPid if it's missing from connection profile #468
• will need another version bump, gateways will be need to be added again

[Jakeeyturner]

Some of the work has been completed for #640. Before this epic is closed, it would be worth checking that that the 'Add Gateway' part of designs in this issue are implemented.

[cazfletch]

done so closing