Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Initial translation support #679

Merged
merged 3 commits into from
Mar 4, 2019
Merged

Initial translation support #679

merged 3 commits into from
Mar 4, 2019

Conversation

jt-nti
Copy link
Contributor

@jt-nti jt-nti commented Mar 1, 2019

Minimal changes required to externalise a string in the typescript
code, and a string in the package.json

Includes build change required to verify which strings have been
externalised using the pseudo locale in locale.json, but does
not include any translated strings or the changes required to
package them.

Contributes to #28

Signed-off-by: James Taylor jamest@uk.ibm.com

Minimal changes required to externalise a string in the typescript
code, and a string in the package.json

Includes build change required to verify which strings have been
externalised using the `pseudo` locale in locale.json, but does
not include any translated strings or the changes required to
package them.

Contributes to #28

Signed-off-by: James Taylor <jamest@uk.ibm.com>
@jt-nti jt-nti requested a review from heatherlp March 4, 2019 13:31
Copy link
Contributor

@heatherlp heatherlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James!

@cazfletch cazfletch merged commit 36a3d99 into IBM-Blockchain:master Mar 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants