Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Clean up the names of the configuration settings #880

Closed
sstone1 opened this issue Apr 30, 2019 · 3 comments
Closed

Clean up the names of the configuration settings #880

sstone1 opened this issue Apr 30, 2019 · 3 comments
Assignees
Milestone

Comments

@sstone1
Copy link
Contributor

sstone1 commented Apr 30, 2019

The extension currently has quite a few configuration settings:

    "fabric.runtime": {
        "ports": {
            "orderer": 17050,
            "peerRequest": 17051,
            "peerChaincode": 17052,
            "peerEventHub": 17053,
            "certificateAuthority": 17054,
            "couchDB": 17055,
            "logs": 17056
        },
        "developmentMode": false
    },
    "fabric.gateways": [],
    "fabric.wallets": [],
    "blockchain.ext.directory": "~/.fabric-vscode",
    "extension.home.showOnStartup": true,
    "blockchain.repositories": []

These names are mixed in with all other configuration settings from all other extensions. They're not in a namespace for our extension. It would be better if these names were consistent - for example, a single ibm-blockchain-platform prefix?

The worst offender is "extension.home.showOnStartup" which doesn't mention blockchain, fabric, or IBM. It could be from any extension!

v1.0.0 is our chance to get this right, so we should change it before GA.

@sstone1 sstone1 added the v1 GA label Apr 30, 2019
@heatherlp
Copy link
Contributor

I still hate the idea of all our old contributions hanging around user settings though :(

@heatherlp
Copy link
Contributor

I am pro them being consistent :)

@cazfletch cazfletch added this to the Sprint 6 milestone May 1, 2019
@Jakeeyturner
Copy link
Contributor

"ibm-blockchain-platform.fabric.runtime": {},
"ibm-blockchain-platform.fabric.gateways": [],
"ibm-blockchain-platform.fabric.wallets": [],
"ibm-blockchain-platform.ext.directory": "~/.fabric-vscode",
"ibm-blockchain-platform.ext.repositories": [],
"ibm-blockchain-platform.home.showOnStartup": true

How about this?

@Jakeeyturner Jakeeyturner self-assigned this May 1, 2019
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue May 1, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue May 2, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue May 2, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue May 3, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue May 3, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue May 3, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue May 7, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue May 7, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants