This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 157
Clean up the names of the configuration settings #880
Milestone
Comments
I still hate the idea of all our old contributions hanging around user settings though :( |
I am pro them being consistent :) |
How about this? |
Jakeeyturner
added a commit
to Jakeeyturner/blockchain-vscode-extension
that referenced
this issue
May 1, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner
added a commit
to Jakeeyturner/blockchain-vscode-extension
that referenced
this issue
May 2, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner
added a commit
to Jakeeyturner/blockchain-vscode-extension
that referenced
this issue
May 2, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner
added a commit
to Jakeeyturner/blockchain-vscode-extension
that referenced
this issue
May 3, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner
added a commit
to Jakeeyturner/blockchain-vscode-extension
that referenced
this issue
May 3, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner
added a commit
to Jakeeyturner/blockchain-vscode-extension
that referenced
this issue
May 3, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner
added a commit
to Jakeeyturner/blockchain-vscode-extension
that referenced
this issue
May 7, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner
added a commit
to Jakeeyturner/blockchain-vscode-extension
that referenced
this issue
May 7, 2019
Signed-off-by: Jake Turner <jaketurner25@live.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The extension currently has quite a few configuration settings:
These names are mixed in with all other configuration settings from all other extensions. They're not in a namespace for our extension. It would be better if these names were consistent - for example, a single
ibm-blockchain-platform
prefix?The worst offender is
"extension.home.showOnStartup"
which doesn't mention blockchain, fabric, or IBM. It could be from any extension!v1.0.0 is our chance to get this right, so we should change it before GA.
The text was updated successfully, but these errors were encountered: