Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Stop users from including a space in smart contract project name #968

Closed
heatherlp opened this issue May 14, 2019 · 2 comments
Closed

Stop users from including a space in smart contract project name #968

heatherlp opened this issue May 14, 2019 · 2 comments
Assignees
@Jakeeyturner
Labels
bug Something isn't working sev2
Milestone
Sprint 8

Comments

@heatherlp
Copy link
Contributor

npm install fails if user includes space in smart contract project name
@cazfletch cazfletch added bug Something isn't working sev2 labels May 14, 2019
@heatherlp heatherlp added this to the Sprint 7 milestone May 21, 2019
@Jakeeyturner
Copy link
Contributor

When packaging a smart contract with the name 1.0.1contract I get:

Invalid smart contract name '1.0.1contract'. Smart contract names must only consist of alphanumerics, '_', and '-'.

This might as well be covered in PR #987 as well!

@heatherlp
Copy link
Contributor Author

I think we definitely need to be smarter about this - the user could select any folder, including Downloads or My Documents and then they'd have smart contracts named to match.

Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue May 28, 2019
@Jakeeyturner
Valid package name fix (close IBM-Blockchain#968)
d47a0b9 
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue May 28, 2019
@Jakeeyturner
Valid package name fix (close IBM-Blockchain#968)
d50c18b 
Signed-off-by: Jake Turner <jaketurner25@live.com>
@cazfletch cazfletch modified the milestones: Sprint 7, Sprint 8 May 28, 2019
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue May 29, 2019
@Jakeeyturner
Valid package name fix (close IBM-Blockchain#968)
679a87a 
Signed-off-by: Jake Turner <jaketurner25@live.com>
Jakeeyturner added a commit to Jakeeyturner/blockchain-vscode-extension that referenced this issue May 29, 2019
@Jakeeyturner
Valid package name fix (close IBM-Blockchain#968)
ce4103a 
Signed-off-by: Jake Turner <jaketurner25@live.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Jakeeyturner Jakeeyturner

Labels
bug Something isn't working sev2
Projects
None yet
Milestone
Sprint 8
Development

No branches or pull requests
4 participants
@Jakeeyturner @SammyRasha @cazfletch @heatherlp