Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves the issue of the user not able to add pipelines to the kabanero custom resource file #13

Merged
merged 4 commits into from
May 11, 2020

Conversation

oiricaud
Copy link
Member

@oiricaud oiricaud commented May 11, 2020

The user was not able to add pipelines to their custom resource upon using the run.sh file.
What caused this issue was that the script was not counting the # of pipelines that currently exist in the kabanero.yaml file.

This pull request resolves that issue by first counting the # of pipelines that exist in the stack key, and incrementing by 1 to add the new pipeline at the bottom.

Given the default kabanero pipelines i.e

    stacks:
      pipelines:
      - https:
          url: https://github.com/kabanero-io/kabanero-pipelines/releases/download/0.6.1/default-kabanero-pipelines.tar.gz
        id: default
        sha256: 64aee2805d36127c2f1e0e5f0fc6fdae5cef19360c1bb506137584f3bd0988cc

where the user wants to add a new pipeline

      - https:
          url: https://github.com/oiricaud/pipelines/releases/download/v60.0/default-kabanero-pipelines.tar.gz
        id: package-release-update-pl
        sha256: 86b1902f9f7ce0911f759bbe9e11c27075a3b1f7cca40de59df19eab9afca45d

The pull request now gives the following results in

    stacks:
      pipelines:
      - https:
          url: https://github.com/kabanero-io/kabanero-pipelines/releases/download/0.6.1/default-kabanero-pipelines.tar.gz
        id: default
        sha256: 64aee2805d36127c2f1e0e5f0fc6fdae5cef19360c1bb506137584f3bd0988cc
      - https:
          url: https://github.com/oiricaud/pipelines/releases/download/v60.0/default-kabanero-pipelines.tar.gz
        id: package-release-update-pl
        sha256: 86b1902f9f7ce0911f759bbe9e11c27075a3b1f7cca40de59df19eab9afca45d

oiricaud and others added 3 commits May 11, 2020 09:02
…issue was the run.sh was not taking into account the # of pipelines that currently exist.
@oiricaud
Copy link
Member Author

Can @hollisc or @andrew-suh do a code review if bandwidth is available.

@oiricaud oiricaud changed the title This PR resolves Issue 11 Resolves the issue of the user not able to add pipelines to the kabanero custom resource file. May 11, 2020
@oiricaud oiricaud changed the title Resolves the issue of the user not able to add pipelines to the kabanero custom resource file. Resolves the issue of the user not able to add pipelines to the kabanero custom resource file May 11, 2020
@hollisc hollisc merged commit 090ebea into ibm-cloud-architecture:master May 11, 2020
@oiricaud oiricaud self-assigned this Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

step 6 is not working and the user is not able to add pipelines to the Kabenero CR
2 participants