rename signin

ibm-cloud-security · Sep 26, 2019 · 868e6c9 · 868e6c9
1 parent 3f226d9
commit 868e6c9
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/dist/appid.min.js b/dist/appid.min.js
diff --git a/dist/appid.umd.min.js b/dist/appid.umd.min.js
diff --git a/sample/public/index.html b/sample/public/index.html
@@ -28,9 +28,9 @@
 <script type='text/javascript' src="appid.min.js"></script>
 <script>
 	function showError(e) {
-        console.error(e);
-        document.getElementById('error').textContent = e;
-        document.getElementById('login').setAttribute('class', 'button');
+		console.error(e);
+		document.getElementById('error').textContent = e;
+		document.getElementById('login').setAttribute('class', 'button');
 	}
 
 	(async function () {
@@ -57,7 +57,7 @@
 			document.getElementById('error').textContent = '';
 
 			try {
-				const tokens = await appID.signinWithPopup();
+				const tokens = await appID.signin();
 				let userInfo = await appID.getUserInfo(tokens.accessToken);
 				let decodeIDToken = tokens.idTokenPayload;
 				document.getElementById('welcome').textContent = 'Hello, ' + decodeIDToken.name;

diff --git a/src/index.js b/src/index.js
@@ -71,7 +71,7 @@ class AppID {
 	 * @throws OAuthError - Any errors from the server. e.g. {error: 'server_error', description: ''}
 	 * @throws RequestError - Any errors during a HTTP request.
 	 */
-	async signinWithPopup() {
+	async signin() {
 		const {codeVerifier, nonce, state, authUrl} = this.utils.getAuthParams(this.clientId, this.window.origin);
 
 		this.popup.open(this.popupConfig);

diff --git a/test/AppIdTest.js b/test/AppIdTest.js
@@ -22,7 +22,7 @@ describe('AppID tests', () => {
 				w: {origin: 'http://localhost:3005'},
 				url: URL
 			});
-			let res = await appID.signinWithPopup();
+			let res = await appID.signin();
 			assert.equal(res.accessToken, 'accessToken');
 			assert.equal(res.idToken, 'idToken');
 			assert.equal(res.accessTokenPayload, 'tokenPayload');
@@ -40,7 +40,7 @@ describe('AppID tests', () => {
 				url: URL
 			});
 			try {
-				await appID.signinWithPopup();
+				await appID.signin();
 			} catch (e) {
 				assert.equal(e.description, constants.INVALID_STATE);
 			}
@@ -58,7 +58,7 @@ describe('AppID tests', () => {
 				url: URL
 			});
 			try {
-				await appID.signinWithPopup();
+				await appID.signin();
 			} catch (e) {
 				assert.equal(e.error, 'access_denied');
 				assert.equal(e.description, 'Could not verify SAML assertion');