Merge dea4e2d into b935d45

ibm-cloud-security · Sep 17, 2019 · 8be8bcc · 8be8bcc
2 parents b935d45 + dea4e2d
commit 8be8bcc
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 25 deletions.
diff --git a/dist/appid.min.js b/dist/appid.min.js
diff --git a/dist/appid.umd.min.js b/dist/appid.umd.min.js
diff --git a/src/PopupController.js b/src/PopupController.js
@@ -5,21 +5,13 @@ class PopupController {
 		this.window = w;
 	};
 
-	open() {
-		const h = 700;
-		const w = 400;
-		const left = (screen.width - w) / 2;
-		const top = (screen.height - h) / 2;
-		this.popup = this.window.open('', 'popup', `left=${left},top=${top},width=${w},height=${h},resizable,scrollbars=yes,status=1`);
+	open({authUrl}) {
+		this.popup = this.window.open(authUrl, '_blank');
 		if (!this.popup) {
 			throw new PopupError('Unable to open popup')
 		}
 	};
 
-	navigate({authUrl}) {
-		this.popup.location.href = authUrl;
-	};
-
 	close() {
 		this.popup.close();
 	}

diff --git a/src/index.js b/src/index.js
@@ -39,8 +39,7 @@ class AppID {
 	async signinWithPopup() {
 		const {codeVerifier, nonce, state, authUrl} = this.getAuthParams();
 
-		this.popup.open();
-		this.popup.navigate({authUrl});
+		this.popup.open({authUrl});
 		const message = await this.popup.waitForMessage({messageType: 'authorization_response'});
 		this.popup.close();