Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idp parameter #46

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dariusbakunas
Copy link

AppID authorization endpoint supports additional idp parameter that allows us to skip initial IDP selection screen when multiple IDP providers are configured. This pull requests adds support for this optional parameter.

AppID /authorization endpoint supports idp paremeter to select an enabled IdP name
@dariusbakunas
Copy link
Author

I tried to follow current convention, but I'm wondering if it would be more useful to add optional parameter to actual login methods, instead of having it in initialization function. We may run into situation where we initialize it once, but use it with different idp settings?

@abod-akhras abod-akhras reopened this Jun 16, 2021
@vladimiratanasov
Copy link
Contributor

@dariusbakunas sorry for the very late reply here, we are going through the PR's and cleaning them up at the moment. I like this addition and also think it would make more sense to add the parameter to the login methods. This way we don't have to lock our applications to one idp. Would you mind making the change and fixing the merge conflicts in the min files?

Thank you

@dariusbakunas
Copy link
Author

@dariusbakunas sorry for the very late reply here, we are going through the PR's and cleaning them up at the moment. I like this addition and also think it would make more sense to add the parameter to the login methods. This way we don't have to lock our applications to one idp. Would you mind making the change and fixing the merge conflicts in the min files?

Thank you

Sry, not really using IBM cloud or AppID anymore, I was part of transition to Merative. I can see if I can setup free account at some point, have more things on my plate at the moment.. this is on my list, but I'm not sure when I will get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants