Initial hubot Cloudant scripts #2
Conversation
| @@ -1,4 +1,89 @@ | |||
| [](https://travis-ci.org/ibm-cloud-solutions/hubot-ibmcloud-cloudant) | |||
| [](https://coveralls.io/github/ibm-cloud-solutions/hubot-ibmcloud-cloudant?branch=cleanup) | |||
There was a problem hiding this comment.
branch should be master. This is a bug in the repo you took this from.
|
Changes Unknown when pulling 6397554 on cloudant-scripts into * on master*. |
| { | ||
| "name": "databasename", | ||
| "type": "entity", | ||
| "prompt": "OK. What is the name of the database for which you want detailed?" |
There was a problem hiding this comment.
for which you want details? vs. detailed
|
Changes Unknown when pulling 5830834 on cloudant-scripts into * on master*. |
|
|
||
| // Passing arrow functions to mocha is discouraged: https://mochajs.org/#arrow-functions | ||
| // return promises from mocha tests rather than calling done() - http://tobyho.com/2015/12/16/mocha-with-promises/ | ||
| describe('Interacting with Cloudant via Slack', function() { |
There was a problem hiding this comment.
Perhaps remove slack and highlight RegEx or Natural Language in describe text
There was a problem hiding this comment.
Reworded all references to slack in the three test files.
|
A couple comments. Also your CLAs are for app-management. You can grab the word docs from the skeleton project and generate the appropriate PDFs. |
…s to slack in test case descriptions.
|
Changes Unknown when pulling 6180e5b on cloudant-scripts into * on master*. |
|
@chambrid I have made all of the review changes including updating the cla docs. Thanks for reviewing. Please let me know if you'd like me to merge this pull request. |
|
Changes Unknown when pulling 3b2a5b2 on cloudant-scripts into * on master*. |
|
👍 |
Initial commit.