added a function to improve conversations with the bot around selecti… #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng options from a numbered list.
|
|
||
| // check < 1 or > 99 | ||
| if (maxNum < 1 || maxNum > 99) { | ||
| return; |
There was a problem hiding this comment.
I wondered if maybe an exception should be thrown, but maybe not. The key will be how the calling code handles the response. Looks like it would need to check for undefined. If that's the case, maybe make a comment to that affect in the function header comments. That way if/when someone goes to use this in the future, there will be a reminder of what to expect.
…est cases to cover upper and lower bounds.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng options from a numbered list.
Tests were added, and the resulting regex were tested in regex101.com