Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent type error exception when 429s are thrown #3

Merged
merged 1 commit into from
Dec 6, 2018
Merged

prevent type error exception when 429s are thrown #3

merged 1 commit into from
Dec 6, 2018

Conversation

jasonpet
Copy link
Contributor

@jasonpet jasonpet commented Dec 6, 2018

When 429s are thrown due to throttling error.error=resp.body is a string so code should only retrieve error.error.errorMessage if type is an object.

@csantanapr csantanapr merged commit 037dc73 into ibm-functions:master Dec 6, 2018
@jasonpet jasonpet deleted the typeError branch December 6, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csantanapr csantanapr csantanapr approved these changes

Assignees

@csantanapr csantanapr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasonpet @csantanapr