Add exerimental multicard mode #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No real redundancy, first just to try out the performance when using two cards. Set ZLIB_CARD=-1 to activate this.
Software like samtools always does deflateInit deflate deflateEnd. If we select the initial card statically. E.g. 0, we will not be able to distribute the load.
To judge if the multicard feature is working nicely, I added some code to dump more statistics e.g. which card executed how many requests (DDCB). In this patch, I also set the worker thread tid to 0, if the init was failing. This avoids problem with pthread_cancel if the thread is already gone because it failed to open the afu e.g. if it is busy by another process in dedicated AFU mode.
No real redundancy, first just to try out the performance when using two cards. Set ZLIB_CARD=-1 to activate this.
Software like samtools always does deflateInit deflate deflateEnd. If we select the initial card statically. E.g. 0, we will not be able to distribute the load.
To judge if the multicard feature is working nicely, I added some code to dump more statistics e.g. which card executed how many requests (DDCB). In this patch, I also set the worker thread tid to 0, if the init was failing. This avoids problem with pthread_cancel if the thread is already gone because it failed to open the afu e.g. if it is busy by another process in dedicated AFU mode.
…into fhaverkamp
…tool Instead of falling back to the environment variables to define the accelerator type and the card number we add some proprietary interfaces to define those for more convenience when using our gzip/gunzip tool.
|
I would like to get those patches in. They do not improve the problem with the 2nd card we are currently having and they do not make it worse. For dedicated mode the changes worked ok so far. |
fhaverkamp
added a commit
that referenced
this pull request
Nov 17, 2015
Add exerimental multicard mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding our experimental multicard mode
Add code to set accelerator and card_no for gzip/gunzip
Enhance statistic printout