Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add has("edge") flag for Edge #57

Closed
kgibb opened this issue Oct 19, 2015 · 3 comments
Closed

add has("edge") flag for Edge #57

kgibb opened this issue Oct 19, 2015 · 3 comments
Assignees
Milestone

Comments

@kgibb
Copy link

kgibb commented Oct 19, 2015

Windows 10. User agent: "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/12.10240"

@wkeese
Copy link
Member

wkeese commented Oct 19, 2015

Yes, of course, has("ie") returns undefined on all browsers except for IE. This is expected behavior.

Although Edge is forked from the IE code base it's technically a separate browser, with a new name. So in the same way that has("safari") returns false on Chrome, has("ie") returns false on Edge. Do you think it should be different?

We should though add a has("edge") flag.

PS: Also, like in dojo V1, need to make sure that has("chrome"), has("safari"), and has("webkit") return undefined on Edge. See dojo/dojo@ac05a45 although that change is incomplete because it forgot has("webkit").

@kgibb
Copy link
Author

kgibb commented Oct 20, 2015

No the has("edge") flag should suffice.

@wkeese
Copy link
Member

wkeese commented Oct 20, 2015

OK, I'll add has("edge") and make sure other flags (has("chrome"), has("safari"), has("webkit"), has("mozilla")) are false.

@wkeese wkeese changed the title has("ie") is returning undefined in Edge add has("edge") flag for Edge Oct 20, 2015
@wkeese wkeese added this to the 0.7.0 milestone Oct 20, 2015
@wkeese wkeese self-assigned this Oct 20, 2015
@wkeese wkeese closed this as completed in b83f0c5 Oct 21, 2015
wkeese added a commit that referenced this issue Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants