Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] incorrect namespace being passed on from cli to ansible-devop from teckton #1034

Merged
merged 3 commits into from
Jun 15, 2024
Merged

[patch] incorrect namespace being passed on from cli to ansible-devop from teckton #1034

merged 3 commits into from
Jun 15, 2024

Conversation

lokesh-sreedhara
Copy link
Contributor

@lokesh-sreedhara lokesh-sreedhara commented Jun 14, 2024 •
edited
Loading

regression issue from support:

don't think the fix works, I have two clients using it (TS016470982 and TS016412820) and both encounter the same issue still.

[4:10](https://ibm-watson-iot.slack.com/archives/D077T998X1V/p1718395809405799)
Even with the namespace specified, it still tries to create the OperatorGroup in redhat-marketplace
Provide DRO Namespace [Default:'redhat-marketplace'] > ibm-common-services
DRO is configured to install in ibm-common-services namespace

TASK [ibm.mas_devops.dro : Check if operator group is present in "redhat-marketplace" already] ***
ok: [localhost] => changed=false 
  api_found: true
  resources: []

TASK [ibm.mas_devops.dro : Create OperatorGroup in redhat-marketplace namespace if not exist] ***
fatal: [localhost]: FAILED! => changed=false 
  error: 403
  msg: 'Namespace redhat-marketplace: Failed to create object: b''{"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"admission webhook \\"namespace-validation.managed.openshift.io\\" denied the request: Prevented from accessing Red Hat managed namespaces. Customer workloads should be placed in customer namespaces, and should not match an entry in this list of regular expressions: [^kube.* ^default$ ^redhat.* ^dedicated-admin$ ^openshift-addon-operator$ ^openshift-aqua$ ^openshift-aws-vpce-operator$ ^openshift-backplane$ ^openshift-backplane-cee$ ^openshift-backplane-csa$ ^openshift-backplane-cse$ ^openshift-backplane-csm$ ^openshift-backplane-managed-scripts$ ^openshift-backplane-mobb$ ^openshift-backplane-srep$ ^openshift-backplane-tam$ ^openshift-cloud-ingress-operator$ ^openshift-codeready-workspaces$ ^openshift-compliance$ ^openshift-compliance-monkey$ ^openshift-container-security$ ^openshift-custom-domains-operator$ ^openshift-customer-monitoring$ ^openshift-deployment-validation-operator$
 (snipped the rest)
  reason: Forbidden
  status: 403

FIX: there was a small typo on the default params which cause this issue. I have fixed it and tested on the dev cluster. here are the results.

here the correct namespace is being now passed into ansible from teckton pipeline.
image

@terenceq terenceq merged commit 3c79035 into master Jun 15, 2024
3 checks passed
@terenceq terenceq deleted the dro-namespace branch June 15, 2024 21:23
karol-czarnecki added a commit that referenced this pull request Jun 17, 2024
@karol-czarnecki
Squashed commit of the following:
c7a3208 
commit 0d48ef2
Author: Sanjay Prabhakar <sanju7216@gmail.com>
Date:   Mon Jun 17 11:10:19 2024 +0100

    [patch] push latest tagged image to quay.io (#1036)

commit 6ae7716
Author: Sanjay Prabhakar <sanju7216@gmail.com>
Date:   Mon Jun 17 11:04:28 2024 +0100

    [patch] workaround for pushing image action in release (#1035)

commit 3c79035
Author: Lokesh <110647904+lokesh-sreedhara@users.noreply.github.com>
Date:   Sat Jun 15 17:23:29 2024 -0400

    [patch] incorrect namespace being passed on from cli to ansible-devop from teckton (#1034)

commit 3e523f5
Author: yuvraj-vansure <81155309+yuvraj-vansure@users.noreply.github.com>
Date:   Fri Jun 14 23:49:51 2024 +0530

    [minor] User defined DRO namespace (#1024)

    Co-authored-by: Yuvraj Vansure <yuvraj.vansure1.ibm.com>

commit e2e9d54
Author: Sanjay Prabhakar <sanju7216@gmail.com>
Date:   Thu Jun 13 01:54:32 2024 +0100

    [patch] Temporay workaround to fix image push action (#1027)

    Co-authored-by: Sanjay Prabhakar <sanjay.prabhakar@uk.ibm.com>

commit 50b1633
Author: Harsh Tamakuwala <31183552+harsh42774@users.noreply.github.com>
Date:   Mon Jun 10 13:27:53 2024 +0530

    [patch] Fixes pipeline to pass podTemplates to FVT test case (#1013)

commit efdecf4
Author: leo-miran <105313348+leo-miran@users.noreply.github.com>
Date:   Fri Jun 7 12:53:32 2024 -0300

    [patch] updating base_output_dir in mg template (#1020)

commit 676c43b
Author: leo-miran <105313348+leo-miran@users.noreply.github.com>
Date:   Thu Jun 6 20:41:52 2024 -0300

    [patch] must-gather file path change for upgrade pipeline (#1015)

    Co-authored-by: Alexandre Quinteiro <alequint@Alexandres-MBP.lan>

commit 5301e8f
Author: anilprajapatiibm <169060963+anilprajapatiibm@users.noreply.github.com>
Date:   Wed Jun 5 19:14:51 2024 +0530

    [minor] Support May Catalog update (#953)

    Co-authored-by: Sanjay Prabhakar <sanjay.prabhakar@uk.ibm.com>

commit c8eff24
Author: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com>
Date:   Wed Jun 5 09:26:24 2024 +0530

    [patch] Install COS and Kafka when Manage is present (#1010)

    Co-authored-by: Alexandre Quinteiro <alequint@Alexandres-MBP.lan>
    Co-authored-by: Alexandre Quinteiro <alefq0@gmail.com>

commit 5875637
Author: Alexandre Quinteiro <alefq0@gmail.com>
Date:   Mon Jun 3 08:05:28 2024 -0300

    [minor] Add install sync point at the end of fvt-launcher (#996)

commit b0fce77
Author: liyongc <liyongc@cn.ibm.com>
Date:   Mon Jun 3 18:03:19 2024 +0800

    [minor]Add podTemplates for manage accelerator (#998)

commit 103b942
Author: prakrutishah06 <109357487+prakrutishah06@users.noreply.github.com>
Date:   Mon Jun 3 15:22:17 2024 +0530

    [patch] Remove esig-basic keyword from last phase  (#959)

commit 6bb36f9
Author: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com>
Date:   Fri May 31 20:44:30 2024 +0530

    [minor] Merge health launcher into manage-is and re-organize some selenium tests (#999)

    Co-authored-by: Alexandre Quinteiro <alefq0@gmail.com>
    Co-authored-by: Alexandre Quinteiro <alequint@Alexandres-MBP.lan>

commit 3f10822
Author: Alona Varshal <thirdwave72@gmail.com>
Date:   Thu May 30 04:21:42 2024 -0500

    [patch] Doc update for catalog guidance (#1005)
karol-czarnecki added a commit that referenced this pull request Jun 21, 2024
@karol-czarnecki
Squashed commit of the following:
5e1fd7d 
commit 57a7d4e
Author: André Marcelino <31037381+andrercm@users.noreply.github.com>
Date:   Thu Jun 20 17:09:35 2024 -0300

    [patch] remove optimizer-manage-setup test (#1046)

commit 5d0a4ba
Author: Jon Levell <jonquark@users.noreply.github.com>
Date:   Thu Jun 20 09:24:29 2024 +0100

    [patch] mustgather: collect iot messaging proxy trace (#1043)

commit 742acc2
Author: Ian Boden <82514609+IanBoden@users.noreply.github.com>
Date:   Tue Jun 18 02:05:08 2024 +0100

    [patch] Fix IoT approval conditional in FVT launcher (#978)

    Co-authored-by: David Parker <parkerda@uk.ibm.com>

commit 3030b05
Author: Alexandre Quinteiro <alefq0@gmail.com>
Date:   Mon Jun 17 21:56:28 2024 -0300

    [patch] Use ignore_failure param in wait task (#1028)

commit 43da893
Author: David Parker <parkerda@uk.ibm.com>
Date:   Tue Jun 18 01:55:22 2024 +0100

    [patch] Convert upgrade & uninstall functions to Python (#1038)

commit f2e77ba
Author: leo-miran <105313348+leo-miran@users.noreply.github.com>
Date:   Mon Jun 17 18:40:26 2024 -0300

    [minor] mobile version finder (#1030)

    Co-authored-by: Alexandre Quinteiro <alefq0@gmail.com>

commit 4894573
Author: Alexandre Quinteiro <alefq0@gmail.com>
Date:   Mon Jun 17 10:17:44 2024 -0300

    [minor] Review fvt-launcher design for manage and its dependencies (#1025)

    Co-authored-by: Alexandre Quinteiro <alequint@Alexandres-MBP.lan>
    Co-authored-by: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com>

commit 0d48ef2
Author: Sanjay Prabhakar <sanju7216@gmail.com>
Date:   Mon Jun 17 11:10:19 2024 +0100

    [patch] push latest tagged image to quay.io (#1036)

commit 6ae7716
Author: Sanjay Prabhakar <sanju7216@gmail.com>
Date:   Mon Jun 17 11:04:28 2024 +0100

    [patch] workaround for pushing image action in release (#1035)

commit 3c79035
Author: Lokesh <110647904+lokesh-sreedhara@users.noreply.github.com>
Date:   Sat Jun 15 17:23:29 2024 -0400

    [patch] incorrect namespace being passed on from cli to ansible-devop from teckton (#1034)

commit 3e523f5
Author: yuvraj-vansure <81155309+yuvraj-vansure@users.noreply.github.com>
Date:   Fri Jun 14 23:49:51 2024 +0530

    [minor] User defined DRO namespace (#1024)

    Co-authored-by: Yuvraj Vansure <yuvraj.vansure1.ibm.com>

commit e2e9d54
Author: Sanjay Prabhakar <sanju7216@gmail.com>
Date:   Thu Jun 13 01:54:32 2024 +0100

    [patch] Temporay workaround to fix image push action (#1027)

    Co-authored-by: Sanjay Prabhakar <sanjay.prabhakar@uk.ibm.com>

commit 50b1633
Author: Harsh Tamakuwala <31183552+harsh42774@users.noreply.github.com>
Date:   Mon Jun 10 13:27:53 2024 +0530

    [patch] Fixes pipeline to pass podTemplates to FVT test case (#1013)

commit efdecf4
Author: leo-miran <105313348+leo-miran@users.noreply.github.com>
Date:   Fri Jun 7 12:53:32 2024 -0300

    [patch] updating base_output_dir in mg template (#1020)

commit 676c43b
Author: leo-miran <105313348+leo-miran@users.noreply.github.com>
Date:   Thu Jun 6 20:41:52 2024 -0300

    [patch] must-gather file path change for upgrade pipeline (#1015)

    Co-authored-by: Alexandre Quinteiro <alequint@Alexandres-MBP.lan>

commit 5301e8f
Author: anilprajapatiibm <169060963+anilprajapatiibm@users.noreply.github.com>
Date:   Wed Jun 5 19:14:51 2024 +0530

    [minor] Support May Catalog update (#953)

    Co-authored-by: Sanjay Prabhakar <sanjay.prabhakar@uk.ibm.com>

commit c8eff24
Author: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com>
Date:   Wed Jun 5 09:26:24 2024 +0530

    [patch] Install COS and Kafka when Manage is present (#1010)

    Co-authored-by: Alexandre Quinteiro <alequint@Alexandres-MBP.lan>
    Co-authored-by: Alexandre Quinteiro <alefq0@gmail.com>

commit 5875637
Author: Alexandre Quinteiro <alefq0@gmail.com>
Date:   Mon Jun 3 08:05:28 2024 -0300

    [minor] Add install sync point at the end of fvt-launcher (#996)

commit b0fce77
Author: liyongc <liyongc@cn.ibm.com>
Date:   Mon Jun 3 18:03:19 2024 +0800

    [minor]Add podTemplates for manage accelerator (#998)

commit 103b942
Author: prakrutishah06 <109357487+prakrutishah06@users.noreply.github.com>
Date:   Mon Jun 3 15:22:17 2024 +0530

    [patch] Remove esig-basic keyword from last phase  (#959)

commit 6bb36f9
Author: unnati-solanki-git <131964221+unnati-solanki-git@users.noreply.github.com>
Date:   Fri May 31 20:44:30 2024 +0530

    [minor] Merge health launcher into manage-is and re-organize some selenium tests (#999)

    Co-authored-by: Alexandre Quinteiro <alefq0@gmail.com>
    Co-authored-by: Alexandre Quinteiro <alequint@Alexandres-MBP.lan>

commit 3f10822
Author: Alona Varshal <thirdwave72@gmail.com>
Date:   Thu May 30 04:21:42 2024 -0500

    [patch] Doc update for catalog guidance (#1005)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terenceq terenceq terenceq approved these changes

@yuvraj-vansure yuvraj-vansure yuvraj-vansure approved these changes

@durera durera Awaiting requested review from durera durera is a code owner

@andrercm andrercm Awaiting requested review from andrercm andrercm is a code owner

@sanjayprab sanjayprab Awaiting requested review from sanjayprab sanjayprab is a code owner

@whitfiea whitfiea Awaiting requested review from whitfiea whitfiea is a code owner

@alequint alequint Awaiting requested review from alequint alequint is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lokesh-sreedhara @terenceq @yuvraj-vansure