Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] add must-gather for Optimizer #815

Merged
merged 3 commits into from Mar 6, 2024
Merged

[patch] add must-gather for Optimizer #815

merged 3 commits into from Mar 6, 2024

Conversation

andrefgj
Copy link
Contributor

@andrefgj andrefgj commented Mar 1, 2024

Test evidence:

4.2) Namespace: mas-opti810x-optimizerCollect Reconcile Logs
- control-plane:ibm-mas-optimizer
- No reconcile logs available in ibm-mas-optimizer-operator-6b6cf57498-b66xr
- mas.ibm.com/appType:entitymgr-ws-operator
  - optimizerworkspace.apps.mas.ibm.com/v1
- mas.ibm.com/applicationId:optimizer
- No reconcile logs available in opti810x-adminui-5bd69b876d-vwm7t
- mas.ibm.com/appType:optimizer-adminui
- No reconcile logs available in opti810x-adminui-5bd69b876d-vwm7t
- mas.ibm.com/appType:optimizer-api
- No reconcile logs available in opti810x-api-69dc94f444-jnrhh
- mas.ibm.com/appType:optimizer-execution-service
- No reconcile logs available in opti810x-masdev-execution-service-5f79594f94-2zlkv

Copy link
Contributor

@alequint alequint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrefgj could you please update PR description with some test evidence indicating the code added worked fine in your tests?

@andrefgj
Copy link
Contributor Author

andrefgj commented Mar 4, 2024

@andrefgj could you please update PR description with some test evidence indicating the code added worked fine in your tests?

Hi @alequint. The test evidence was provided in the description. Just let me know if it is enough, OK?

Thanks!

@andrefgj andrefgj requested a review from alequint March 4, 2024 13:31
Copy link
Contributor

@andrercm andrercm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alequint alequint merged commit 31bf6ef into master Mar 6, 2024
2 checks passed
@alequint alequint deleted the andrefgj-mso409 branch March 6, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants