-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patch] UDS/DRO migration storage class fix #849
Conversation
cam someone help review/approve this PR for merge? |
@yuvraj-vansure @lokesh-sreedhara have you tested if this works as expected for both interactive/non-interactive aproaches and also including |
@andrercm ohh i did not check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be approved to be merged due time constraints, but adjustments will be implemented so that code follows same standard as other implementations in the MAS CLI.
I had a review session with Lokesh and Yuvraj and we identified some enhancements to be done:
- Add logic in
update
pipeline to skipuds
task based onUDS_ACTION
valid values, instead of addingskip
action into ansible-devops role... If a task must be skipped, it should be proactively skipped in the pipeline instead of being skipped in the role execution. - Fix the logic on how the DRO_STORAGE_CLASS is determined so it follows same standards as the other places where we define the storage classes. Use https://github.com/ibm-mas/cli/blob/master/image/cli/mascli/functions/internal/install_config_storage_classes as example.
depending Ansible PR
ibm-mas/ansible-devops#1263