Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] UDS/DRO migration storage class fix #849

Merged
merged 30 commits into from Apr 8, 2024
Merged

[patch] UDS/DRO migration storage class fix #849

merged 30 commits into from Apr 8, 2024

Conversation

yuvraj-vansure
Copy link
Contributor

@yuvraj-vansure yuvraj-vansure commented Mar 20, 2024

  • MASCORE-2054: prompt user for storgaclass during uds to dro migration.
  • removed mirror-dro flag from help doc
  • Added skip check for UDS/DRO if DRO already exists during migration.

depending Ansible PR
ibm-mas/ansible-devops#1263

@yuvraj-vansure yuvraj-vansure marked this pull request as ready for review March 22, 2024 02:55
whitfiea
whitfiea previously approved these changes Mar 25, 2024
@lokesh-sreedhara
Copy link
Contributor

cam someone help review/approve this PR for merge?

@andrercm
Copy link
Contributor

andrercm commented Apr 5, 2024

@yuvraj-vansure @lokesh-sreedhara have you tested if this works as expected for both interactive/non-interactive aproaches and also including --no-confirm argument?

@lokesh-sreedhara
Copy link
Contributor

@yuvraj-vansure @lokesh-sreedhara have you tested if this works as expected for both interactive/non-interactive aproaches and also including --no-confirm argument?

@andrercm ohh i did not check --no-confirm. @yuvraj-vansure can u help with this? when mas update --no-confirm is run, it should overide all user prompts, make sure DRO_STORAGE_CLASS takes default value "" on --no-confirm

@lokesh-sreedhara lokesh-sreedhara self-requested a review April 5, 2024 22:26
Copy link
Contributor

@andrercm andrercm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be approved to be merged due time constraints, but adjustments will be implemented so that code follows same standard as other implementations in the MAS CLI.

I had a review session with Lokesh and Yuvraj and we identified some enhancements to be done:

image/cli/install-ansible/ibm-mas_devops.tar.gz Outdated Show resolved Hide resolved
build/bin/build-tekton.sh Outdated Show resolved Hide resolved
@andrercm andrercm merged commit 7cbcc81 into master Apr 8, 2024
2 checks passed
@andrercm andrercm deleted the mascore-2054 branch April 8, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants