[minor] Capture cp4d and components versions #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creyesibm
requested review from
durera,
andrercm,
sanjayprab,
terenceq and
whitfiea
as code owners
alequint
approved these changes
Apr 4, 2024
|
This is awesome @creyesibm ! And it looks good to me! We need to keep an eye on it when we start using next CPD @andrercm had been working on... because versions may not be obtained from the same place then. But I see the code here is a tolerance to versions not found, so we should be safe for now. |
alequint
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added code to capture CP4D version and versions from its components.
Tested the changes from the dashboard and everything looks good:
For environments without CP4D then a simple dash will be displayed without a pop-up.
