Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interval variable init in main.go of mq_aws #192

Closed
lavalex opened this issue Dec 14, 2022 · 1 comment
Closed

Interval variable init in main.go of mq_aws #192

lavalex opened this issue Dec 14, 2022 · 1 comment

Comments

@lavalex
Copy link

lavalex commented Dec 14, 2022

Hello,

I think there is a type in main.go of mq_aws in line 49:

	d, err := time.ParseDuration(interval)

Which from what I understand, creates a local variable and then "d" goes back to zero, so the loop never "sleeps".

Should be:

           d, err = time.ParseDuration(interval)
@ibmmqmet
Copy link
Collaborator

ibmmqmet commented Jan 3, 2023

Yes you are right. I'll fix it for the next release. Thanks for finding it.

ibmmqmet added a commit that referenced this issue Jan 10, 2023
@ibmmqmet
* Copy in metrics.txt summary of available metrics from mq-golang
24c1cc7 
* JSON exporter - consistent objecttype for qmgr, merge published and
  polled metrics (#188)
* JSON exporter - allow configuration (`recordmax`) for number of objects
  printed in a single JSON record (also #188)
* AWS exporter -correct interval processing (#192)
* Simplified build/run in a single Dockerfile (#194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibmmqmet @lavalex