Add Typescript types #134
Merged
Add Typescript types #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- stretch has python 3.5; node-gyp needs 3.6+, so bump up to bullseye - Use the same version of node in the builder as in the runtime container (16) - Copy all of the samples
# Conflicts: # package.json # samples/Dockerfile
|
Would be great to have this one merged 🚀 |
Updates to the types
|
Once again, thanks for the work on this. It's now been merged and published as part of 0.9.20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure all items are complete before opening.
What
Added typescript definition files.
How
Adde Typescript definition files for the JS API to the types/ folder, and converted samples to TS.
Testing
The sample files should compile and run.
Issues
#132