1050: Redfish: Check snmpTrap port

[ChicagoDuan]

Check snmpTrap port

1. Allow empty port, eg:
   "snmp://9.41.166.76:".
2. Invalid ports and out of range ports are not allowed, eg:
   "snmp://9.41.166.76:ab"
   "snmp://9.41.166.76:-40"
   "snmp://9.41.166.76:65536".

Test:

1. Empty port:
curl -k -H "X-Auth-Token: $bmc_token" -X POST -D headers.txt
 https://${bmc}/redfish/v1/EventService/Subscriptions
-d '{"Destination":"snmp://9.41.166.76:",
 "SubscriptionType":"SNMPTrap", "Protocol":"SNMPv2c"}'
{
  "@Message.ExtendedInfo": [
    {
      "@odata.type": "#Message.v1_1_1.Message",
      "Message": "The resource has been created successfully.",
      "MessageArgs": []

,
      "MessageId": "Base.1.13.0.Created",
      "MessageSeverity": "OK",
      "Resolution": "None."
    }
  ]
}

2. Invalid port:
curl -k -H "X-Auth-Token: $bmc_token" -X POST -D headers.txt
 https://${bmc}/redfish/v1/EventService/Subscriptions
 -d '{"Destination":"snmp://9.41.166.76:ab",
 "SubscriptionType":"SNMPTrap", "Protocol":"SNMPv2c"}'
{
  "Destination@Message.ExtendedInfo": [
    {
      "@odata.type": "#Message.v1_1_1.Message",
      "Message": "The value 'snmp://9.41.166.76:ab' for the property Destination is of a different format than the property can accept.",
      "MessageArgs": [
        "snmp://9.41.166.76:ab",
        "Destination"
      ],
      "MessageId": "Base.1.13.0.PropertyValueFormatError",
      "MessageSeverity": "Warning",
      "Resolution": "Correct the value for the property in the request body and resubmit the request if the operation failed."
    }
  ]

curl -k -H "X-Auth-Token: $bmc_token" -X POST -D headers.txt
 https://${bmc}/redfish/v1/EventService/Subscriptions
 -d '{"Destination":"snmp://9.41.166.76:-40",
 "SubscriptionType":"SNMPTrap", "Protocol":"SNMPv2c"}'
{
  "Destination@Message.ExtendedInfo": [
    {
      "@odata.type": "#Message.v1_1_1.Message",
      "Message": "The value 'snmp://9.41.166.76:-40' for the property Destination is of a different format than the property can accept.",
      "MessageArgs": [
        "snmp://9.41.166.76:-40",
        "Destination"
      ],
      "MessageId": "Base.1.13.0.PropertyValueFormatError",
      "MessageSeverity": "Warning",
      "Resolution": "Correct the value for the property in the request body and resubmit the request if the operation failed."
    }
  ]
}

3. Out of range port:
curl -k -H "X-Auth-Token: $bmc_token" -X POST -D headers.txt
 https://${bmc}/redfish/v1/EventService/Subscriptions
 -d '{"Destination":"snmp://9.41.166.76:65536",
 "SubscriptionType":"SNMPTrap", "Protocol":"SNMPv2c"}'
{
  "Destination@Message.ExtendedInfo": [
    {
      "@odata.type": "#Message.v1_1_1.Message",
      "Message": "The value 'snmp://9.41.166.76:65536' for the property Destination is of a different format than the property can accept.",
      "MessageArgs": [
        "snmp://9.41.166.76:65536",
        "Destination"
      ],
      "MessageId": "Base.1.13.0.PropertyValueFormatError",
      "MessageSeverity": "Warning",
      "Resolution": "Correct the value for the property in the request body and resubmit the request if the operation failed."
    }
  ]
}

[ChicagoDuan]

CI failed because this patch(1050 clang16) is not merged: #687

[gtmills]

@ChicagoDuan Is there an upstream change here ?

[ChicagoDuan]

@ChicagoDuan Is there an upstream change here ?

Yes, upstream has the same problem, I will push it to the upstream.