Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Assembly Resource To Populate Status::State #3476

Closed
gtmills opened this issue Feb 3, 2022 · 2 comments
Closed

Update Assembly Resource To Populate Status::State #3476

gtmills opened this issue Feb 3, 2022 · 2 comments
Assignees
Milestone

Comments

@gtmills
Copy link

gtmills commented Feb 3, 2022

Similar to how we look at Operational Status to set the Status::Health Redfish property (See ibm-openbmc/bmcweb#202), we can look at the Present property on D-Bus to set the Status::State property

If Present is true, set Status::State to Enabled, else set it to Absent.

We do this for other resources like:
https://github.com/ibm-openbmc/bmcweb/blob/1020/redfish-core/lib/power_supply.hpp#L134

ibm-openbmc/bmcweb#247 is same issue

@gtmills gtmills added the ReadyForDev Stories ready for development work label Feb 3, 2022
@gtmills gtmills added this to the A.1.221.1 milestone Feb 3, 2022
@gtmills gtmills removed the ReadyForDev Stories ready for development work label Feb 4, 2022
@SunnySrivastava1984
Copy link

Code updated under PR
ibm-openbmc/bmcweb#256

@mzipse
Copy link
Contributor

mzipse commented Nov 30, 2022

Work is complete. Closing.

@mzipse mzipse closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants